Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2077153002: Worker: Record time taken for running a debugger/worker task on WorkerThread (Closed)

Created:
4 years, 6 months ago by nhiroki
Modified:
4 years, 6 months ago
Reviewers:
kinuko, Steven Holte
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, asvitkine+watch_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Record time taken for running a debugger/worker task on WorkerThread UMA to record duration of a debugger/worker task would be helpful to determine a delay for a task of forcible worker thread shutdown. BUG=616721 Committed: https://crrev.com/cc65b94db2ebe5b99396f1cabb520f4dc1d8c259 Cr-Commit-Position: refs/heads/master@{#401759}

Patch Set 1 #

Patch Set 2 : fix crashes on tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 chunks +10 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
nhiroki
ptal
4 years, 6 months ago (2016-06-17 22:47:10 UTC) #2
nhiroki
On 2016/06/17 22:47:10, nhiroki wrote: > ptal Hmm... some tests are failing because of this ...
4 years, 6 months ago (2016-06-20 08:50:49 UTC) #3
nhiroki
On 2016/06/20 08:50:49, nhiroki wrote: > On 2016/06/17 22:47:10, nhiroki wrote: > > ptal > ...
4 years, 6 months ago (2016-06-23 15:14:50 UTC) #7
nhiroki
On 2016/06/23 15:14:50, nhiroki wrote: > On 2016/06/20 08:50:49, nhiroki wrote: > > On 2016/06/17 ...
4 years, 6 months ago (2016-06-23 15:24:58 UTC) #8
kinuko
lgtm
4 years, 6 months ago (2016-06-23 15:44:17 UTC) #9
nhiroki
On 2016/06/23 15:44:17, kinuko wrote: > lgtm Thank you!
4 years, 6 months ago (2016-06-23 15:56:39 UTC) #10
nhiroki
+holte@, could you review histograms.xml? Thanks.
4 years, 6 months ago (2016-06-23 15:57:18 UTC) #12
Steven Holte
lgtm
4 years, 6 months ago (2016-06-23 20:34:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077153002/20001
4 years, 6 months ago (2016-06-24 00:39:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-24 00:46:01 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 00:47:23 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc65b94db2ebe5b99396f1cabb520f4dc1d8c259
Cr-Commit-Position: refs/heads/master@{#401759}

Powered by Google App Engine
This is Rietveld 408576698