Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2077133002: Make Android back work correctly in Elderberry. (Closed)

Created:
4 years, 6 months ago by Ted C
Modified:
4 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Android back work correctly in Elderberry. Prior to this if you have previously ever launched the tabbed mode of Chrome, clicking on the back button of an elderberry tab would refocus Chrome instead of the app that launched it (only for versions launched with NEW_TASK). BUG=582539 Committed: https://crrev.com/21d50a521d5818df323f612c33da4ee0213aa203 Cr-Commit-Position: refs/heads/master@{#400747}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -52 lines) Patch
M chrome/android/java/AndroidManifest.xml View 3 chunks +6 lines, -7 lines 2 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java View 4 chunks +1 line, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ted C
PTAL
4 years, 6 months ago (2016-06-17 22:08:13 UTC) #2
Maria
lgtm This is scary. https://codereview.chromium.org/2077133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2077133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode142 chrome/android/java/AndroidManifest.xml:142: android:taskAffinity="" The only thing I ...
4 years, 6 months ago (2016-06-17 22:35:51 UTC) #3
Ted C
https://codereview.chromium.org/2077133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2077133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode142 chrome/android/java/AndroidManifest.xml:142: android:taskAffinity="" On 2016/06/17 22:35:51, Maria wrote: > The only ...
4 years, 6 months ago (2016-06-20 15:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077133002/1
4 years, 6 months ago (2016-06-20 18:36:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 19:25:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 19:27:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21d50a521d5818df323f612c33da4ee0213aa203
Cr-Commit-Position: refs/heads/master@{#400747}

Powered by Google App Engine
This is Rietveld 408576698