Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2077113002: Handle interfaces with a ServiceName in the go bindings generator. (Closed)

Created:
4 years, 6 months ago by azani
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Handle interfaces with a ServiceName in the go bindings generator. R=vardhan@google.com, vardhan Committed: https://chromium.googlesource.com/external/mojo/+/76480d3166bf10966515cd5230bc5fce49e42a3f

Patch Set 1 #

Patch Set 2 : Fix names issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -8 lines) Patch
M mojom/generators/go/templates/interfaces.go View 3 chunks +42 lines, -0 lines 0 comments Download
M mojom/generators/go/templates/interfaces_test.go View 1 chunk +25 lines, -0 lines 0 comments Download
M mojom/generators/go/templates/templates.go View 1 chunk +4 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/mojom_file.go View 2 chunks +4 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/names.go View 1 1 chunk +10 lines, -6 lines 0 comments Download
M mojom/generators/go/translator/translator.go View 2 chunks +6 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/types.go View 1 1 chunk +13 lines, -2 lines 0 comments Download
M mojom/generators/go/translator/types_test.go View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
azani
4 years, 6 months ago (2016-06-17 21:55:54 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-20 23:42:15 UTC) #2
azani
4 years, 6 months ago (2016-06-20 23:44:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
76480d3166bf10966515cd5230bc5fce49e42a3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698