chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2077063002: MD Settings: Allow the user to order the list of languages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2077063002: MD Settings: Allow the user to order the list of languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_types.js ('k') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 263be6c6fa154f1d961a71f56bd7f545db3d68d4..12781d43df6359c04f4648e7aaac6661d41dca29 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -598,6 +598,12 @@ void AddLanguagesStrings(content::WebUIDataSource* html_source) {

LocalizedString localized_strings[] = {

{"languagesPageTitle", IDS_SETTINGS_LANGUAGES_PAGE_TITLE},

{"languagesListTitle", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_TITLE},

+ {"orderLanguagesInstructions",

+ IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_ORDERING_INSTRUCTIONS},

+ {"moveUp", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_UP},

+ {"moveDown", IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_MOVE_DOWN},

+ {"languageDetail",

+ IDS_SETTINGS_LANGUAGES_LANGUAGES_LIST_LANGUAGE_DETAIL},

{"manageLanguages", IDS_SETTINGS_LANGUAGES_LANGUAGES_MANAGE},

#if defined(OS_CHROMEOS)

{"inputMethodsListTitle",

@@ -640,6 +646,10 @@ void AddLanguagesStrings(content::WebUIDataSource* html_source) {

};

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

+ html_source->AddString(

+ "languagesLearnMoreURL",

+ base::ASCIIToUTF16(chrome::kLanguageSettingsLearnMoreUrl));

}

#if defined(OS_CHROMEOS)