Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2077063002: MD Settings: Allow the user to order the list of languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 606ba89f53e86fff1f5f5d604a11b15945fca943..f559f593bcecd13f6e323d5979527ba830299ffe 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -71,10 +71,6 @@ Polymer({
if (!cr.isChromeOS && !cr.isWindows)
return;
- // Taps on the paper-icon-button are handled in onShowLanguageDetailTap_.
- if (e.target.tagName == 'PAPER-ICON-BUTTON')
- return;
-
// Set the prospective UI language. This won't take effect until a restart.
if (e.model.item.language.supportsUI)
this.languageHelper_.setUILanguage(e.model.item.language.code);
@@ -104,6 +100,54 @@ Polymer({
},
/**
+ * @param {number} index Index of the language in the list of languages.
+ * @param {!Object} change Polymer change object for languages.enabled.*.
+ * @return {boolean} True if the given language is the first one in the list
+ * of languages.
+ * @private
+ */
+ isFirstLanguage_: function(index, change) {
+ return index == 0;
+ },
+
+ /**
+ * @param {number} index Index of the language in the list of languages.
+ * @param {!Object} change Polymer change object for languages.enabled.*.
+ * @return {boolean} True if the given language is the last one in the list of
+ * languages.
+ * @private
+ */
+ isLastLanguage_: function(index, change) {
+ return index == this.languages.enabled.length - 1;
+ },
+
+ /**
+ * @param {!Object} change Polymer change object for languages.enabled.*.
+ * @return {boolean} True if there are less than 2 languages.
+ */
+ isHelpTextHidden_: function(change) {
+ return this.languages.enabled.length <= 1;
+ },
+
+ /**
+ * Moves the language up in the list.
+ * @param {!{model: !{item: !LanguageState}}} e
+ * @private
+ */
+ onMoveUpTap_: function(e) {
+ this.languageHelper_.moveLanguage(e.model.item.language.code, -1);
+ },
+
+ /**
+ * Moves the language down in the list.
+ * @param {!{model: !{item: !LanguageState}}} e
+ * @private
+ */
+ onMoveDownTap_: function(e) {
+ this.languageHelper_.moveLanguage(e.model.item.language.code, 1);
+ },
+
+ /**
* Opens the Language Detail page for the language.
* @param {!{model: !{item: !LanguageState}}} e
* @private

Powered by Google App Engine
This is Rietveld 408576698