Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2077063002: MD Settings: Allow the user to order the list of languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index f3222f8ecf7544defa2da36ac088ecc4e59f225e..b782e258e92389bd6ca3203f05caa217c13c0006 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -82,10 +82,11 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
});
test('language detail', function() {
- var languageButton = languagesPage.$.languagesCollapse.querySelector(
- '.list-item paper-icon-button[icon="cr:settings"]');
- assertTrue(!!languageButton);
- MockInteractions.tap(languageButton);
+ var languagesCollapse = languagesPage.$.languagesCollapse;
+ var languageDetailMenuItem = languagesCollapse.querySelectorAll(
michaelpg 2016/06/27 22:24:01 querySelector(...) is equivalent to querySelectorA
Moe 2016/06/28 14:28:23 yes. I meant to make it clear to readers of these
+ '.dropdown-content .language-detail-item')[0];
+ assertTrue(!!languageDetailMenuItem);
+ MockInteractions.tap(languageDetailMenuItem);
var languageDetailPage = languagesPage.$$(
'settings-language-detail-page');

Powered by Google App Engine
This is Rietveld 408576698