chrome/test/data/webui/settings/languages_page_browsertest.js - Issue 2077063002: MD Settings: Allow the user to order the list of languages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2077063002: MD Settings: Allow the user to order the list of languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed broken tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('K') | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | chrome/test/data/webui/settings/languages_page_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/languages_page_browsertest.js

diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js

index f3222f8ecf7544defa2da36ac088ecc4e59f225e..1ffb505a2022abfd530dce091a82ea33073f1b4a 100644

--- a/chrome/test/data/webui/settings/languages_page_browsertest.js

+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js

@@ -82,10 +82,11 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {

});

test('language detail', function() {

- var languageButton = languagesPage.$.languagesCollapse.querySelector(

- '.list-item paper-icon-button[icon="cr:settings"]');

- assertTrue(!!languageButton);

- MockInteractions.tap(languageButton);

+ var languagesCollapse = languagesPage.$.languagesCollapse;

+ var languageDetailMenuItem = languagesCollapse.querySelector(

+ '.dropdown-content #languageDetail');

+ assertTrue(!!languageDetailMenuItem);

+ MockInteractions.tap(languageDetailMenuItem);

var languageDetailPage = languagesPage.$$(

'settings-language-detail-page');