Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2718)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2077063002: MD Settings: Allow the user to order the list of languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed broken tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 6135b9301fad03a392b9d2a2fc36a0ce2afdff74..63aef54043702c3f38c3523624aa4d09b5d6e1c6 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -25,7 +25,16 @@
<dom-module id="settings-languages-page">
<template>
- <style include="settings-shared"></style>
+ <style include="settings-shared">
+ .dropdown-content {
+ background: white;
+ box-shadow: 0 2px 6px grey;
+ }
+
+ paper-item:hover {
+ background-color: var(--settings-hover-color);
+ }
+ </style>
<settings-languages languages="{{languages}}"></settings-languages>
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="languages">
@@ -43,6 +52,13 @@
</div>
<iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]">
<div class="list-frame vertical-list">
+ <span class="list-item"
+ hidden="[[isHelpTextHidden_(languages.enabled.*)]]">
+ <span>$i18n{orderLanguagesInstructions}</span>
+ <a href="$i18n{languagesLearnMoreURL}" target="_blank">
+ $i18n{learnMore}
+ </a>
+ </span>
<template is="dom-repeat" items="[[languages.enabled]]">
<div class$="list-item [[getLanguageItemClass_(
item.language.code, prefs.intl.app_locale.value)]]"
@@ -63,8 +79,28 @@
</iron-icon>
</div>
</if>
- <paper-icon-button icon="cr:settings"
- on-tap="onShowLanguageDetailTap_"></paper-icon-button>
+ <paper-icon-button icon="cr:more-vert" toggles
+ active="{{item.optionsMenuOpened}}">
+ </paper-icon-button>
+ <iron-dropdown opened="{{item.optionsMenuOpened}}"
michaelpg 2016/06/21 00:34:42 I noticed some issues here, but they exist elsewhe
Moe 2016/06/21 20:10:19 Acknowledged. I've seen the gray focus ring in MD
+ horizontal-align="right" vertical-align="top">
+ <div class="dropdown-content">
+ <paper-item on-tap="onMoveUpTap_" id="moveUp"
michaelpg 2016/06/21 00:34:42 an id in a dom-repeat doesn't make sense (it'll be
Moe 2016/06/21 20:10:19 Yep. this is wrong. Changed it to "moveUp-[[item.l
michaelpg 2016/06/22 01:06:27 Looks like we only use these IDs for testing, and
Moe 2016/06/27 15:00:05 Done.
+ hidden="[[isFirstLanguage_(index,
+ languages.enabled.*)]]">
+ $i18n{moveUp}
+ </paper-item>
+ <paper-item on-tap="onMoveDownTap_" id="moveDown"
michaelpg 2016/06/21 00:34:42 id?
Moe 2016/06/21 20:10:19 Done.
+ hidden="[[isLastLanguage_(index,
+ languages.enabled.*)]]">
michaelpg 2016/06/21 00:34:42 align as on 90
Moe 2016/06/21 20:10:19 Done.
+ $i18n{moveDown}
+ </paper-item>
+ <paper-item id="languageDetail"
michaelpg 2016/06/21 00:34:42 id?
Moe 2016/06/21 20:10:19 Done.
+ on-tap="onShowLanguageDetailTap_">
+ $i18n{languageDetail}
+ </paper-item>
+ </div>
+ </iron-dropdown>
</div>
</template>
<div class="list-item list-button" on-tap="onManageLanguagesTap_">

Powered by Google App Engine
This is Rietveld 408576698