MD Settings: Allow the user to order the list of languages.

chrome/test/data/webui/settings/languages_page_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-languages-page. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 64 matching lines @@
     }.bind(this));
 
     test('manage languages', function() {
       var manageLanguagesButton =
           languagesPage.$.languagesCollapse.querySelector('.list-button');
       MockInteractions.tap(manageLanguagesButton);
       assertTrue(!!languagesPage.$$('settings-manage-languages-page'));
     });
 
     test('language detail', function() {
-      var languageButton = languagesPage.$.languagesCollapse.querySelector(
-          '.list-item paper-icon-button[icon="cr:settings"]');
-      assertTrue(!!languageButton);
-      MockInteractions.tap(languageButton);
+      var languagesCollapse = languagesPage.$.languagesCollapse;
+      var languageDetailMenuItem = languagesCollapse.querySelectorAll(

[michaelpg, 2016/06/27 22:24:01]

querySelector(...) is equivalent to querySelectorAll(...)[0] when there's at
least one item to find

[Moe, 2016/06/28 14:28:23]

yes. I meant to make it clear to readers of these tests that there are multiple
items to choose from. It wasn't very clear to me when I first read the test.

+          '.dropdown-content .language-detail-item')[0];
+      assertTrue(!!languageDetailMenuItem);
+      MockInteractions.tap(languageDetailMenuItem);
 
       var languageDetailPage = languagesPage.$$(
           'settings-language-detail-page');
       assertTrue(!!languageDetailPage);
       assertEquals('en-US', languageDetailPage.detail.language.code);
     });
 
     test('manage input methods', function() {
       var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse;
       var inputMethodSettingsExist = !!inputMethodsCollapse;
@@ skipping 19 matching lines @@
         assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
       }
     });
   }.bind(this));
 
   // TODO(michaelpg): Test more aspects of the languages UI.
 
   // Run all registered tests.
   mocha.run();
 });