Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2077043002: Update GYP for linux Vulkan to support SDK 1.0.13 (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update GYP for linux Vulkan to support SDK 1.0.13 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2077043002 Committed: https://skia.googlesource.com/skia/+/58daedb12ee2e910d351825bbf72c1a8c72748fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M gyp/gpu.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
egdaniel
With this change you will be required the set the VULKAN_SDK variable on linux.
4 years, 6 months ago (2016-06-17 18:32:37 UTC) #3
jvanverth1
So we'll need to set VULKAN_SDK_PATH in our shell?
4 years, 6 months ago (2016-06-17 18:39:51 UTC) #4
jvanverth1
On 2016/06/17 18:39:51, jvanverth1 wrote: > So we'll need to set VULKAN_SDK_PATH in our shell? ...
4 years, 6 months ago (2016-06-17 18:40:09 UTC) #5
egdaniel
Yes. We're going to have to do it at some point if we ever want ...
4 years, 6 months ago (2016-06-17 18:43:19 UTC) #6
jvanverth1
lgtm
4 years, 6 months ago (2016-06-17 18:44:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077043002/1
4 years, 6 months ago (2016-06-17 18:50:49 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 19:04:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/58daedb12ee2e910d351825bbf72c1a8c72748fc

Powered by Google App Engine
This is Rietveld 408576698