Issue 207703004: Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207703004: Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source. (Closed)

Created:
6 years, 9 months ago by marja

Modified:
6 years, 9 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Tentative Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source. For more information, see the bug. Compare to ScriptOrigin which is not exported either. BUG=v8:3228 LOG=Y R=dcarney@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20170

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

marja

6 years, 9 months ago (2014-03-21 15:24:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20170 (presubmit successful).