Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 207703003: Revert "Use constant length for memcpy on A64 simulator." (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Revert "Use constant length for memcpy on A64 simulator." This reverts commit r20141 which broke the build with some GCC versions. The reason behind that is GCC emits a warning about code which can never be reached, but GCC can't figure that out. The right approach would be using template specialization instead of these runtime if/then/else cascades, which would be nicer from a SW engineering perspective, too. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M src/a64/simulator-a64.h View 2 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
Committed patchset #1 manually as r20142 (tree was closed).
6 years, 9 months ago (2014-03-21 08:03:32 UTC) #1
Yang
6 years, 9 months ago (2014-03-21 08:04:05 UTC) #2
Message was sent while issue was closed.
On 2014/03/21 08:03:32, Sven Panne wrote:
> Committed patchset #1 manually as r20142 (tree was closed).

rubberstamp lgtm.

Powered by Google App Engine
This is Rietveld 408576698