GpuVideoDecoder should reject playback of videos with alpha channel.

GpuVideoDecoder should reject playback of videos with alpha channel.

This channel is not decoded by the hardware decoder, so we should
force these to fallback to software decoding.

BUG=621135
TEST=http://simpl.info/videoalpha

Committed: https://crrev.com/6a4d01c7fda0bf54c847ee1198a3a3e4670f8e27
Cr-Commit-Position: refs/heads/master@{#400477}

[DaleCurtis, 2016-06-17 17:58:26]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org

[DaleCurtis, 2016-06-17 17:58:26]

We could also extend capabilities and use IsOpaque(), but this seemed a safer
change for now.

[sandersd (OOO until July 31), 2016-06-17 18:09:19]

lgtm

https://codereview.chromium.org/2077023002/diff/1/media/filters/gpu_video_dec...
File media/filters/gpu_video_decoder.cc (right):

https://codereview.chromium.org/2077023002/diff/1/media/filters/gpu_video_dec...
media/filters/gpu_video_decoder.cc:187: if (config.format() ==
PIXEL_FORMAT_YV12A) {
Please add a TODO to move this to capabilities, since it is conceivable that
some platforms could support such things, or to expose it in VDA::Config so that
each VDA can decide.

Not also that VDA::Config recently got |supported_output_formats|, but its use
is the inverse of this.

[DaleCurtis, 2016-06-17 18:19:50]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-06-17 18:19:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2077023002/#ps20001
(title: "TODO")

[DaleCurtis, 2016-06-17 18:19:56]

https://codereview.chromium.org/2077023002/diff/1/media/filters/gpu_video_dec...
File media/filters/gpu_video_decoder.cc (right):

https://codereview.chromium.org/2077023002/diff/1/media/filters/gpu_video_dec...
media/filters/gpu_video_decoder.cc:187: if (config.format() ==
PIXEL_FORMAT_YV12A) {
On 2016/06/17 at 18:09:19, sandersd wrote:
> Please add a TODO to move this to capabilities, since it is conceivable that
some platforms could support such things, or to expose it in VDA::Config so that
each VDA can decide.
> 
> Not also that VDA::Config recently got |supported_output_formats|, but its use
is the inverse of this.

Done.

[commit-bot: I haz the power, 2016-06-17 18:20:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077023002/20001

[commit-bot: I haz the power, 2016-06-17 19:46:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 19:47:32]

Description was changed from

==========
GpuVideoDecoder should reject playback of videos with alpha channel.

This channel is not decoded by the hardware decoder, so we should
force these to fallback to software decoding.

BUG=621135
TEST=http://simpl.info/videoalpha
==========

to

==========
GpuVideoDecoder should reject playback of videos with alpha channel.

This channel is not decoded by the hardware decoder, so we should
force these to fallback to software decoding.

BUG=621135
TEST=http://simpl.info/videoalpha

Committed: https://crrev.com/6a4d01c7fda0bf54c847ee1198a3a3e4670f8e27
Cr-Commit-Position: refs/heads/master@{#400477}
==========

[commit-bot: I haz the power, 2016-06-17 19:47:34]

Patchset 2 (id:??) landed as
https://crrev.com/6a4d01c7fda0bf54c847ee1198a3a3e4670f8e27
Cr-Commit-Position: refs/heads/master@{#400477}