Issue 20770002: Ignore +grit entries in DEPS files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20770002: Ignore +grit entries in DEPS files. (Closed)

Created:
7 years, 5 months ago by tony

Modified:
7 years, 5 months ago

Reviewers:
M-A Ruel, Jói

CC:
chromium-reviews, jackhou1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Ignore +grit entries in DEPS files. Sometimes the trailing slash doesn't exist on the DEPS on grit, but we were expecting it. BUG=None R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213989

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -14 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+21 lines, -14 lines	0 comments	Download
	M	PRESUBMIT_test.py	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

tony

This was causing the commit bot to reject the patch on https://codereview.chromium.org/19490002/ .

7 years, 5 months ago (2013-07-26 17:09:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/20770002/1

7 years, 5 months ago (2013-07-26 18:44:18 UTC) #3

tony

7 years, 5 months ago (2013-07-26 21:39:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r213989 (presubmit successful).