Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2076853002:
Remove all the @FlakyTest annotations in ImeTest & fix another flaky test (Closed)
|
Created:
4 years, 6 months ago by yabinh Modified:
4 years, 6 months ago Reviewers:
Changwan Ryu CC:
chromium-reviews, darin-cc_chromium.org, jam, aelias_OOO_until_Jul13 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove all the @FlakyTest annotations in ImeTest & fix another flaky test
The CL
https://codereview.chromium.org/2058633004/
was reverted because another CL is flaky:
https://codereview.chromium.org/2033723003/
There is race condition in the latter CL. Firstly, we copy some text
(running on UI thread), then we copy other text (running on test thread).
At last we paste the text. But we are not sure which text is in the
clipboard because of race condition. We can fix this by not copying the
former text, because it is not necessary originally. After fixing it,
we can remove the @FlakyTest annotations safely.
BUG=598482, 603991
Committed: https://crrev.com/f667465a379f9d74f97590399fe7aff97e7a637b
Cr-Commit-Position: refs/heads/master@{#400386}
Patch Set 1 #Patch Set 2 #
Messages
Total messages: 15 (8 generated)
Description was changed from ========== remove all the @FlakyTest annotations in ImeTest & fix another flaky test This cl https://codereview.chromium.org/2058633004/ was reverted because another cl is flaky: https://codereview.chromium.org/2033723003/ We should fix the latter cl. Thus, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== remove all the @FlakyTest annotations in ImeTest & fix another flaky test This cl https://codereview.chromium.org/2058633004/ was reverted because another cl is flaky: https://codereview.chromium.org/2033723003/ We should fix the latter cl. Thus, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ==========
yabinh@chromium.org changed reviewers: + changwan@chromium.org
On 2016/06/17 02:21:31, yabinh wrote: > mailto:yabinh@chromium.org changed reviewers: > + mailto:changwan@chromium.org changwan@, can you take a look at this cl?
Please explain in the description why / how the flakiness issue can be fixed. Also nits: 1) Please captalize the first character in the subject. 3) Add a blank line before BUG= line. 4) In the description, replace 'This CL' by 'The CL'. It is referring to the CL in the same sentence, and use of 'This' doesn't make much sense.
Description was changed from ========== remove all the @FlakyTest annotations in ImeTest & fix another flaky test This cl https://codereview.chromium.org/2058633004/ was reverted because another cl is flaky: https://codereview.chromium.org/2033723003/ We should fix the latter cl. Thus, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text(running on UI thread), then we copy other text (running on test thread). At last we paste the text into the clipboard. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ==========
Description was changed from ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text(running on UI thread), then we copy other text (running on test thread). At last we paste the text into the clipboard. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text(running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ==========
Description was changed from ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text(running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text (running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ==========
On 2016/06/17 03:55:40, Changwan Ryu wrote: > Please explain in the description why / how the flakiness issue can be fixed. > > Also nits: > 1) Please captalize the first character in the subject. > 3) Add a blank line before BUG= line. > 4) In the description, replace 'This CL' by 'The CL'. It is referring to the CL > in the same sentence, and use of 'This' doesn't make much sense. changwan@, the description has been changed. Can you take another look?
On 2016/06/17 05:54:57, yabinh wrote: > On 2016/06/17 03:55:40, Changwan Ryu wrote: > > Please explain in the description why / how the flakiness issue can be fixed. > > > > Also nits: > > 1) Please captalize the first character in the subject. > > 3) Add a blank line before BUG= line. > > 4) In the description, replace 'This CL' by 'The CL'. It is referring to the > CL > > in the same sentence, and use of 'This' doesn't make much sense. > > changwan@, the description has been changed. Can you take another look? lgtm
The CQ bit was checked by yabinh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076853002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text (running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text (running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text (running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 ========== to ========== Remove all the @FlakyTest annotations in ImeTest & fix another flaky test The CL https://codereview.chromium.org/2058633004/ was reverted because another CL is flaky: https://codereview.chromium.org/2033723003/ There is race condition in the latter CL. Firstly, we copy some text (running on UI thread), then we copy other text (running on test thread). At last we paste the text. But we are not sure which text is in the clipboard because of race condition. We can fix this by not copying the former text, because it is not necessary originally. After fixing it, we can remove the @FlakyTest annotations safely. BUG=598482, 603991 Committed: https://crrev.com/f667465a379f9d74f97590399fe7aff97e7a637b Cr-Commit-Position: refs/heads/master@{#400386} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f667465a379f9d74f97590399fe7aff97e7a637b Cr-Commit-Position: refs/heads/master@{#400386} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
