Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 20768002: Remove unused methods from RuntimeProfiler (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 4 months ago
Reviewers:
Benedikt Meurer, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Remove unused methods from RuntimeProfiler Also removed Logger fields that used to be used for writing compressed logs. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15941

Patch Set 1 #

Patch Set 2 : log.h cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M src/log.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/log.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime-profiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 5 months ago (2013-07-26 16:57:13 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-27 07:42:45 UTC) #2
yurys
@bmeurer: can you do OWNER review?
7 years, 4 months ago (2013-07-29 18:08:27 UTC) #3
Benedikt Meurer
LGTM
7 years, 4 months ago (2013-07-29 18:13:40 UTC) #4
yurys
7 years, 4 months ago (2013-07-29 19:02:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698