media/audio/audio_output_device.h - Issue 2076793002: Cleanup AudioDeviceThread to reduce locking and unused features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_output_device.h

Issue 2076793002: Cleanup AudioDeviceThread to reduce locking and unused features. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Relocate one-time use variables. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/audio_output_device.h

diff --git a/media/audio/audio_output_device.h b/media/audio/audio_output_device.h

index 23f416c8832a21c29b63763fb260fcd6dbadf913..945e77b638f49cf1019ee7bd3bfdcfb4c2091fe2 100644

--- a/media/audio/audio_output_device.h

+++ b/media/audio/audio_output_device.h

@@ -199,8 +199,8 @@ class MEDIA_EXPORT AudioOutputDevice

// In order to avoid a race between OnStreamCreated and Stop(), we use this

// guard to control stopping and starting the audio thread.

base::Lock audio_thread_lock_;

- AudioDeviceThread audio_thread_;

std::unique_ptr<AudioOutputDevice::AudioThreadCallback> audio_callback_;

+ std::unique_ptr<AudioDeviceThread> audio_thread_;

// Temporary hack to ignore OnStreamCreated() due to the user calling Stop()

// so we don't start the audio thread pointing to a potentially freed

« no previous file with comments | « media/audio/audio_input_device.cc ('k') | media/audio/audio_output_device.cc » ('j') | no next file with comments »