Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2076763004: Use ENABLE_DISABLE_VALUE_TYPE for storage-manager switch and enable it by default on dev. (Closed)

Created:
4 years, 6 months ago by fukino
Modified:
4 years, 6 months ago
Reviewers:
Mark P, Dan Beam, Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ENABLE_DISABLE_VALUE_TYPE for storage-manager switch and enable it by default on dev. This CL does: - Modify storage manager's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value. - Enable storage manager by default on dev channel. BUG=591958 Committed: https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a Cr-Commit-Position: refs/heads/master@{#401693}

Patch Set 1 #

Patch Set 2 : Update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
fukino
mpearson@, PTAL at histograms.xml? estade@, PTAL the rest? Thank you!
4 years, 6 months ago (2016-06-17 20:41:53 UTC) #3
Evan Stade
lgtm
4 years, 6 months ago (2016-06-17 20:56:10 UTC) #4
Mark P
histograms.xml lgtm
4 years, 6 months ago (2016-06-20 20:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076763004/20001
4 years, 6 months ago (2016-06-22 03:56:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/204769)
4 years, 6 months ago (2016-06-22 04:03:23 UTC) #9
fukino
Dan, PTAL at chrome/browser/ui/webui/options/browser_options_handler.cc. Thanks!
4 years, 6 months ago (2016-06-22 14:41:35 UTC) #11
Dan Beam
lgtm
4 years, 6 months ago (2016-06-23 03:19:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076763004/20001
4 years, 6 months ago (2016-06-23 17:14:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/92710)
4 years, 6 months ago (2016-06-23 18:40:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076763004/20001
4 years, 6 months ago (2016-06-23 19:46:50 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 19:53:09 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:55:51 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a
Cr-Commit-Position: refs/heads/master@{#401693}

Powered by Google App Engine
This is Rietveld 408576698