Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2076763003: Disable Array.prototype.values (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable Array.prototype.values It still seems to break things in the wild, see attached Chromium bug for details. BUG=v8:4247, chromium:615873 Committed: https://crrev.com/43a10a0c4a3f3ba859fab199227590bc79a608d2 Cr-Commit-Position: refs/heads/master@{#37064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 6 months ago (2016-06-17 09:09:13 UTC) #2
neis
lgtm
4 years, 6 months ago (2016-06-17 10:35:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076763003/1
4 years, 6 months ago (2016-06-17 10:35:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 10:37:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 10:40:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a10a0c4a3f3ba859fab199227590bc79a608d2
Cr-Commit-Position: refs/heads/master@{#37064}

Powered by Google App Engine
This is Rietveld 408576698