Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2076753002:
Enable WKWebView phone number detection. (Closed)
DescriptionEnable WKWebView phone number detection.
Set dataDetectorTypes on the WKWebView configuration to enable Phone
Numbers on web pages to be automatically clickable.
BUG=467213
Committed: https://crrev.com/f7cc3350fd1c5e4055b3fb52394137c8b61d49f2
Cr-Commit-Position: refs/heads/master@{#400340}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Add iOS10 helper, add guards. #Patch Set 3 : Remove iOS10 helpers from this CL. #Patch Set 4 : Remove iOS10 helpers from this CL. #
Depends on Patchset: Messages
Total messages: 22 (11 generated)
michaeldo@chromium.org changed reviewers: + marq@chromium.org
eugenebut@chromium.org changed reviewers: + eugenebut@chromium.org
https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... File ios/web/web_state/ui/wk_web_view_configuration_provider.mm (right): https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... ios/web/web_state/ui/wk_web_view_configuration_provider.mm:66: if (base::ios::IsRunningOnOrLater(10, 0, 0)) { Could you please add IsRunningOnIOS10OrLater to base/ios/ios_util https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... ios/web/web_state/ui/wk_web_view_configuration_provider.mm:67: [configuration_ setDataDetectorTypes:WKDataDetectorTypePhoneNumber]; This will not compile with iOS9 SDK, so you should use ifdef guards: // TODO(crbug.com/) Remove these guards after moving to iOS10 SDK. #if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0
michaeldo@chromium.org changed reviewers: + rohitrao@chromium.org
https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... File ios/web/web_state/ui/wk_web_view_configuration_provider.mm (right): https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... ios/web/web_state/ui/wk_web_view_configuration_provider.mm:66: if (base::ios::IsRunningOnOrLater(10, 0, 0)) { On 2016/06/16 21:39:59, Eugene But wrote: > Could you please add IsRunningOnIOS10OrLater to base/ios/ios_util Done. https://codereview.chromium.org/2076753002/diff/1/ios/web/web_state/ui/wk_web... ios/web/web_state/ui/wk_web_view_configuration_provider.mm:67: [configuration_ setDataDetectorTypes:WKDataDetectorTypePhoneNumber]; On 2016/06/16 21:39:59, Eugene But wrote: > This will not compile with iOS9 SDK, so you should use ifdef guards: > > // TODO(crbug.com/) Remove these guards after moving to iOS10 SDK. > #if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0 > Done.
ios/web lgtm Ideally you should land base/ios changes separately :)
On 2016/06/16 22:09:44, Eugene But wrote: > ios/web lgtm > > Ideally you should land base/ios changes separately :) Makes sense, moved that change out into 2077693002.
Description was changed from ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 ========== to ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 ==========
michaeldo@chromium.org changed reviewers: - rohitrao@chromium.org
michaeldo@chromium.org changed reviewers: - marq@chromium.org
The CQ bit was checked by michaeldo@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2076753002/#ps60001 (title: "Remove iOS10 helpers from this CL.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076753002/60001
Message was sent while issue was closed.
Description was changed from ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 ========== to ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 ========== to ========== Enable WKWebView phone number detection. Set dataDetectorTypes on the WKWebView configuration to enable Phone Numbers on web pages to be automatically clickable. BUG=467213 Committed: https://crrev.com/f7cc3350fd1c5e4055b3fb52394137c8b61d49f2 Cr-Commit-Position: refs/heads/master@{#400340} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f7cc3350fd1c5e4055b3fb52394137c8b61d49f2 Cr-Commit-Position: refs/heads/master@{#400340}
Message was sent while issue was closed.
futrega@gmail.com changed reviewers: + futrega@gmail.com
Message was sent while issue was closed.
Chrome on iOS with number/date detection enabled is making pages look and work differently then the default iOS browser (Safari). This can totally screw up page content if detection is not working correctly and there is no way for pages to disable this detection. Please revert the changes and make ios chrome display pages like the default browser.
Message was sent while issue was closed.
On 2016/10/21 16:03:10, mfut wrote: > Chrome on iOS with number/date detection enabled is making pages look and work > differently then the default iOS browser (Safari). > > This can totally screw up page content if detection is not working correctly and > there is no way for pages to disable this detection. > > Please revert the changes and make ios chrome display pages like the default > browser. mfut@ if you see concrete problems, please file bug(s) for them. Thanks!
Message was sent while issue was closed.
On 2016/10/24 16:16:18, Eugene But wrote: > On 2016/10/21 16:03:10, mfut wrote: > > Chrome on iOS with number/date detection enabled is making pages look and > work > > differently then the default iOS browser (Safari). > > > > This can totally screw up page content if detection is not working correctly > and > > there is no way for pages to disable this detection. > > > > Please revert the changes and make ios chrome display pages like the default > > browser. Just FYI :) https://codereview.chromium.org/2456533002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
