Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2076743002: Deprecate EmbedderUriResolver (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -35 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +17 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 6 months ago (2016-06-16 21:20:56 UTC) #2
pquitslund
LGTM!
4 years, 6 months ago (2016-06-16 22:13:38 UTC) #3
Brian Wilkerson
4 years, 6 months ago (2016-06-17 14:44:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b522d50d0dd38b03860ddceb2315fed31a587ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698