Move type tagging logic out of setSignature

Move type tagging logic out of setSignature

setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/682bc485b084313592aaf5a52df84a66958796af

[andrewkrieger, 2016-06-16 20:18:27]

Description was changed from

==========
Move type tagging logic out of setSignature

setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.
==========

to

==========
Move type tagging logic out of setSignature

setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.
==========

[andrewkrieger, 2016-06-16 20:18:27]

andrewkrieger@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[Jennifer Messerly, 2016-06-24 22:01:31]

Oops just saw this. LGTM!

[andrewkrieger, 2016-06-24 22:55:41]

I think I forgot to publish comments, so it never notified anyone. I'll rebase,
review the change, and submit next week.

[andrewkrieger, 2016-06-27 17:56:36]

The third patch set fixes compile-time errors in
test/codegen/language/runtime_type_test.dart.

This slipped by me at first because I was running tool/test.sh instead of
tool/presubmit.sh. If I understand correctly, tool/test.sh generates all the
tests, then (assuming the compilation succeeded) prints the confusing message
"All tests pass". I'd propose changing that message to something like "All tests
compile - use tool/browser_test.sh to run them".

I'll send a new CL out in a few minutes to update the message at the end of
test.sh.

[Jennifer Messerly, 2016-06-27 18:04:01]

LGTM++. And great idea on the test.sh message fix!

https://codereview.chromium.org/2076713002/diff/40001/test/codegen/language/r...
File test/codegen/language/runtime_type_test.dart (right):

https://codereview.chromium.org/2076713002/diff/40001/test/codegen/language/r...
test/codegen/language/runtime_type_test.dart:31:
Expect.isFalse(classA.runtimeType == f.runtimeType);
Oh nice fix!

Should we add a test like:

Expect.isTrue(classA.runtimeType == f.runtimeType.runtimeType);


Basically, the type of a function type should get us back to Type.

[andrewkrieger, 2016-06-27 22:24:54]

https://codereview.chromium.org/2076713002/diff/40001/test/codegen/language/r...
File test/codegen/language/runtime_type_test.dart (right):

https://codereview.chromium.org/2076713002/diff/40001/test/codegen/language/r...
test/codegen/language/runtime_type_test.dart:31:
Expect.isFalse(classA.runtimeType == f.runtimeType);
On 2016/06/27 18:04:01, John Messerly wrote:
> Oh nice fix!
> 
> Should we add a test like:
> 
> Expect.isTrue(classA.runtimeType == f.runtimeType.runtimeType);
> 
> 
> Basically, the type of a function type should get us back to Type.

Done. Will land the CL soon.

[andrewkrieger, 2016-06-27 22:29:18]

Description was changed from

==========
Move type tagging logic out of setSignature

setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.
==========

to

==========
Move type tagging logic out of setSignature

setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/682bc485b084313592aaf5a52df8...
==========

[andrewkrieger, 2016-06-27 22:29:20]

Committed patchset #3 (id:40001) manually as
682bc485b084313592aaf5a52df84a66958796af (presubmit successful).