GN style guide on static_libs and source_sets

GN style guide on static_libs and source_sets

Updates usage advice on static libraries and source sets, and adds new advice
on using shared libraries and loadable modules.

Committed: https://crrev.com/9ac2fda6cf5a17902fbb42013e4137e219fb7901
Cr-Commit-Position: refs/heads/master@{#400257}

[brettw, 2016-06-16 19:38:41]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-16 20:01:27]

lgtm w/ one potential clarification.

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.md
File tools/gn/docs/style_guide.md (right):

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.m...
tools/gn/docs/style_guide.md:84: order makes sense to you.
Nit: I would've thought the prior indentation was correct.

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.m...
tools/gn/docs/style_guide.md:170: linking later targets.
This really applies to code that is exported from a component, but not code that
is simply needed internally by the component. It might help to be slightly
clearer about that.

[brettw, 2016-06-16 20:27:36]

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.md
File tools/gn/docs/style_guide.md (right):

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.m...
tools/gn/docs/style_guide.md:84: order makes sense to you.
On 2016/06/16 20:01:27, Dirk Pranke wrote:
> Nit: I would've thought the prior indentation was correct.

Whoops, it sure looks wrong though.

https://codereview.chromium.org/2076703002/diff/1/tools/gn/docs/style_guide.m...
tools/gn/docs/style_guide.md:170: linking later targets.
On 2016/06/16 20:01:27, Dirk Pranke wrote:
> This really applies to code that is exported from a component, but not code
that
> is simply needed internally by the component. It might help to be slightly
> clearer about that.

That's true, but I think a lot of people don't see the difference. I bet it's
very uncommon for a part of a component to have no exported files, and people
will always come later and add stuff. I think it's better for always be
consistent for stuff that goes into components.

[brettw, 2016-06-16 20:27:47]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-06-16 20:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2076703002/#ps20001
(title: "format")

[commit-bot: I haz the power, 2016-06-16 20:28:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076703002/20001

[commit-bot: I haz the power, 2016-06-16 21:13:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 21:15:16]

Description was changed from

==========
GN style guide on static_libs and source_sets

Updates usage advice on static libraries and source sets, and adds new advice
on using shared libraries and loadable modules.
==========

to

==========
GN style guide on static_libs and source_sets

Updates usage advice on static libraries and source sets, and adds new advice
on using shared libraries and loadable modules.

Committed: https://crrev.com/9ac2fda6cf5a17902fbb42013e4137e219fb7901
Cr-Commit-Position: refs/heads/master@{#400257}
==========

[commit-bot: I haz the power, 2016-06-16 21:15:17]

Patchset 2 (id:??) landed as
https://crrev.com/9ac2fda6cf5a17902fbb42013e4137e219fb7901
Cr-Commit-Position: refs/heads/master@{#400257}