Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20767002: Merge 15827, 15842, and 15912 into 3.19 (Closed)

Created:
7 years, 4 months ago by danno
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merge 15827, 15842, and 15912 into 3.19 Unify SoftDeoptimize and Deoptimize hydrogen instructions Fix assert/crash in HandlePolymorphicCallNamed caused by 15827 Add regression test for chromium:258519 BUG=chromium:258519 TEST=test/mjsunit/regress/regress-crbug-258519.js R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16046

Patch Set 1 #

Patch Set 2 : Improve merge #

Patch Set 3 : Final version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -297 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 2 9 chunks +74 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 56 chunks +115 lines, -112 lines 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +10 lines, -59 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-258519.js View 1 2 1 chunk +12 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
PTAL
7 years, 4 months ago (2013-07-26 17:34:00 UTC) #1
danno
7 years, 4 months ago (2013-07-26 17:34:17 UTC) #2
Jakob Kummerow
LGTM!
7 years, 4 months ago (2013-07-27 19:11:41 UTC) #3
danno
Committed patchset #3 manually as r16046 (presubmit successful).
7 years, 4 months ago (2013-08-05 09:53:27 UTC) #4
ulan
7 years, 4 months ago (2013-08-13 12:06:14 UTC) #5
Message was sent while issue was closed. 
On 2013/08/05 09:53:27, danno wrote:
> Committed patchset #3 manually as r16046 (presubmit successful).

This merged did not update version.cc

Powered by Google App Engine
This is Rietveld 408576698