Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2076683002: ABANDONED. Remove obsolete git cl dcommit. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 4 months ago
Reviewers:
benry, agable, Michael Moss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@dcommit-warn
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ABANDONED. Remove obsolete git cl dcommit. R=mmoss@chromium.org,benhenry@chromium.org BUG=600451

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -109 lines) Patch
M git_cl.py View 1 10 chunks +29 lines, -91 lines 1 comment Download
M tests/git_cl_test.py View 1 chunk +0 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076683002/20001
4 years, 6 months ago (2016-06-16 20:20:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/646)
4 years, 6 months ago (2016-06-16 20:27:16 UTC) #4
tandrii(chromium)
PTAL && WDYT?
4 years, 4 months ago (2016-08-15 12:58:18 UTC) #6
Michael Moss
https://codereview.chromium.org/2076683002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2076683002/diff/20001/git_cl.py#newcode4134 git_cl.py:4134: print('Are you sure you didn\'t mean \'git cl dcommit\'?') ...
4 years, 4 months ago (2016-08-15 15:26:32 UTC) #7
agable
I was planning to remove all SVN functionality from depot_tools in one go, and to ...
4 years, 4 months ago (2016-08-15 16:26:05 UTC) #8
tandrii(chromium)
4 years, 4 months ago (2016-08-15 17:44:55 UTC) #9
On 2016/08/15 16:26:05, agable wrote:
> I was planning to remove all SVN functionality from depot_tools in one go, and
> to send a PSA at the same time. But if you want to do this bit yourself, go
for
> it. I defer to mmoss for the review itself since he's already started.

oh, if so, i'll let you, because git cl dcommit is tested elsewhere in
depot_tools, i believe some kind of smoke tests that actually run it end to end.
SO, this CL is ABANDONED.

Powered by Google App Engine
This is Rietveld 408576698