Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/public/platform/WebSourceBuffer.h

Issue 2076673005: MSE: Plumb ChunkDemuxer appendData failures into append Error algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebSourceBuffer.h
diff --git a/third_party/WebKit/public/platform/WebSourceBuffer.h b/third_party/WebKit/public/platform/WebSourceBuffer.h
index 73955dce946dad0b294ad0759f85092ab5611fdb..b577cfc7a32d4a91b49c96d70b8c92d546cfb9f3 100644
--- a/third_party/WebKit/public/platform/WebSourceBuffer.h
+++ b/third_party/WebKit/public/platform/WebSourceBuffer.h
@@ -37,6 +37,9 @@ namespace blink {
class WebSourceBufferClient;
+// Interface for actuating the media engine implementation of Media Source
+// extension's SourceBuffer. See also the mediasource module in Blink, and the
+// WebSourceBufferClient interface.
class WebSourceBuffer {
public:
enum AppendMode {
@@ -63,7 +66,9 @@ public:
// Appends data and runs the segment parser loop algorithm.
// The algorithm may update |*timestampOffset| if |timestampOffset| is not null.
- virtual void append(const unsigned char* data, unsigned length, double* timestampOffset) = 0;
+ // Returns true on success, otherwise the append error algorithm needs to
+ // run with the decode error parameter set to true.
+ virtual bool append(const unsigned char* data, unsigned length, double* timestampOffset) = 0;
virtual void resetParserState() = 0;
virtual void remove(double start, double end) = 0;

Powered by Google App Engine
This is Rietveld 408576698