Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

Issue 2076673005: MSE: Plumb ChunkDemuxer appendData failures into append Error algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
index 2d3875287011b20775c6a6d57ccc93b2b88bbf5c..c07de5489701cca2eef69a891f1077ccabe9c2f5 100644
--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
@@ -116,6 +116,17 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
+ enum AppendStreamDoneAction {
+ NoError,
+ RunAppendErrorWithNoDecodeError,
+ RunAppendErrorWithDecodeError
+ };
+
+ enum AppendError {
+ NoDecodeError,
+ DecodeError
+ };
+
SourceBuffer(std::unique_ptr<WebSourceBuffer>, MediaSource*, GenericEventQueue*);
void dispose();
@@ -126,13 +137,13 @@ private:
bool evictCodedFrames(size_t newDataSize);
void appendBufferInternal(const unsigned char*, unsigned, ExceptionState&);
void appendBufferAsyncPart();
- void appendError(bool decodeError);
+ void appendError(AppendError);
void removeAsyncPart();
void appendStreamInternal(Stream*, ExceptionState&);
void appendStreamAsyncPart();
- void appendStreamDone(bool success);
+ void appendStreamDone(AppendStreamDoneAction);
void clearAppendStreamState();
void removeMediaTracks();

Powered by Google App Engine
This is Rietveld 408576698