MSE: Plumb ChunkDemuxer appendData failures into append Error algorithm

third_party/WebKit/public/platform/WebSourceBuffer.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef WebSourceBuffer_h
 #define WebSourceBuffer_h
 
 #include "WebTimeRange.h"
 
 namespace blink {
 
 class WebSourceBufferClient;
 
 class WebSourceBuffer {

[dcheng, 2016/06/18 06:20:06]

This is obviously a preexisting class, but do you mind adding a comment that
this is for MSE and what it's role is? It's not immediately obvious from the
name what a "source buffer" is.

[wolenetz, 2016/06/21 19:38:09]

Done - and I added a small comment to the top of WebSourceBufferClient.h, too.

 public:
     enum AppendMode {
         AppendModeSegments,
         AppendModeSequence
     };
 
     virtual ~WebSourceBuffer() { }
 
     // This will only be called once and only with a non-null pointer to a
     // client whose ownership is not transferred to this WebSourceBuffer.
     virtual void setClient(WebSourceBufferClient*) = 0;
 
     virtual bool setMode(AppendMode) = 0;
     virtual WebTimeRanges buffered() = 0;
 
     // Run coded frame eviction/garbage collection algorithm.
     // |currentPlaybackTime| is HTMLMediaElement::currentTime. The algorithm
     // will try to preserve data around current playback position.
     // |newDataSize| is size of new data about to be appended to SourceBuffer.
     // Could be zero for appendStream if stream size is unknown in advance.
     // Returns false if buffer is still full after eviction.
     virtual bool evictCodedFrames(double currentPlaybackTime, size_t newDataSize) = 0;
 
     // Appends data and runs the segment parser loop algorithm.
     // The algorithm may update |*timestampOffset| if |timestampOffset| is not null.
-    virtual void append(const unsigned char* data, unsigned length, double* timestampOffset) = 0;
+    // Returns true on success, otherwise the append error algorithm needs to
+    // run with the decode error parameter set to true.
+    virtual bool append(const unsigned char* data, unsigned length, double* timestampOffset) = 0;
 
     virtual void resetParserState() = 0;
     virtual void remove(double start, double end) = 0;
     virtual bool setTimestampOffset(double) = 0;
 
     // Set presentation timestamp for the start of append window.
     virtual void setAppendWindowStart(double) = 0;
 
     // Set presentation timestamp for the end of append window.
     virtual void setAppendWindowEnd(double) = 0;
 
     // After this method is called, this WebSourceBuffer should never use the
     // client pointer passed to setClient().
     virtual void removedFromMediaSource() = 0;
 };
 
 } // namespace blink
 
 #endif