MSE: Plumb ChunkDemuxer appendData failures into append Error algorithm

third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 113 matching lines @@
     bool prepareAppend(size_t newDataSize, ExceptionState&);
     bool evictCodedFrames(size_t newDataSize);
     void appendBufferInternal(const unsigned char*, unsigned, ExceptionState&);
     void appendBufferAsyncPart();
     void appendError(bool decodeError);
 
     void removeAsyncPart();
 
     void appendStreamInternal(Stream*, ExceptionState&);
     void appendStreamAsyncPart();
-    void appendStreamDone(bool success);
+
+    // |decodeError| is only valid if |runAppendError| is true.

[foolip, 2016/06/20 12:04:17]

Smells like this should be a 3-state enum?

[wolenetz, 2016/06/21 19:38:09]

I was thinking similarly and certainly would have done that already if this
method were public. I changed to using an enum. And will do the same in future
per Blink code style that recommends this :)

I also updated the ::appendError(..) method to take an enum instead of a bool,
following that same code style.

[foolip, 2016/06/22 12:39:52]

Yay :)

+    void appendStreamDone(bool runAppendError, bool decodeError);
+
     void clearAppendStreamState();
 
     void removeMediaTracks();
 
     // FileReaderLoaderClient interface
     void didStartLoading() override;
     void didReceiveDataForClient(const char* data, unsigned dataLength) override;
     void didFinishLoading() override;
     void didFail(FileError::ErrorCode) override;
 
@@ skipping 22 matching lines @@
     bool m_streamMaxSizeValid;
     unsigned long long m_streamMaxSize;
     Member<AsyncMethodRunner<SourceBuffer>> m_appendStreamAsyncPartRunner;
     Member<Stream> m_stream;
     OwnPtr<FileReaderLoader> m_loader;
 };
 
 } // namespace blink
 
 #endif // SourceBuffer_h