Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h

Issue 2076663004: Control data saver pingback reporting fraction with protobuf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
index 9cfe056d8293e20949fc97d25bc2e3b0a936bb92..7c5e09c960ea8e336deb9dbf86d721846e576afa 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
@@ -96,20 +96,21 @@ class MockDataReductionProxyRequestOptions
// finely controlling the backoff timer.
class TestDataReductionProxyConfigServiceClient
: public DataReductionProxyConfigServiceClient {
public:
TestDataReductionProxyConfigServiceClient(
std::unique_ptr<DataReductionProxyParams> params,
DataReductionProxyRequestOptions* request_options,
DataReductionProxyMutableConfigValues* config_values,
DataReductionProxyConfig* config,
DataReductionProxyEventCreator* event_creator,
+ DataReductionProxyIOData* io_data,
net::NetLog* net_log,
ConfigStorer config_storer);
~TestDataReductionProxyConfigServiceClient() override;
using DataReductionProxyConfigServiceClient::OnIPAddressChanged;
void SetNow(const base::Time& time);
void SetCustomReleaseTime(const base::TimeTicks& release_time);
@@ -185,48 +186,61 @@ class MockDataReductionProxyService : public DataReductionProxyService {
// the constructor in favor of explicitly passing in its owned classes. This
// permits the use of test/mock versions of those classes.
class TestDataReductionProxyIOData : public DataReductionProxyIOData {
public:
TestDataReductionProxyIOData(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
std::unique_ptr<DataReductionProxyConfig> config,
std::unique_ptr<DataReductionProxyEventCreator> event_creator,
std::unique_ptr<DataReductionProxyRequestOptions> request_options,
std::unique_ptr<DataReductionProxyConfigurator> configurator,
- std::unique_ptr<DataReductionProxyConfigServiceClient> config_client,
net::NetLog* net_log,
bool enabled);
~TestDataReductionProxyIOData() override;
void SetDataReductionProxyService(base::WeakPtr<DataReductionProxyService>
data_reduction_proxy_service) override;
DataReductionProxyConfigurator* configurator() const {
return configurator_.get();
}
+ void set_config_client(
+ std::unique_ptr<DataReductionProxyConfigServiceClient> config_client) {
+ config_client_ = std::move(config_client);
+ }
DataReductionProxyConfigServiceClient* config_client() const {
return config_client_.get();
}
void SetSimpleURLRequestContextGetter(
const scoped_refptr<net::URLRequestContextGetter> context_getter) {
basic_url_request_context_getter_ = context_getter;
}
base::WeakPtr<DataReductionProxyIOData> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
+ // Records the reporting fraction that was set by parsing a config.
+ void SetPingbackReportingFraction(float pingback_reporting_fraction) override;
+
+ float pingback_reporting_fraction() const {
+ return pingback_reporting_fraction_;
+ }
+
private:
// Allowed SetDataReductionProxyService to be re-entrant.
bool service_set_;
+
+ // Reporting fraction last set via SetPingbackReportingFraction.
+ float pingback_reporting_fraction_;
};
// Test version of |DataStore|. Uses an in memory hash map to store data.
class TestDataStore : public data_reduction_proxy::DataStore {
public:
TestDataStore();
~TestDataStore() override;
void InitializeOnDBThread() override {}

Powered by Google App Engine
This is Rietveld 408576698