Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2076653002: handle configparser rename in python3 (Closed)

Created:
4 years, 6 months ago by vapier
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

handle configparser rename in python3 The ConfigParser module was renamed to configparser, so update the two modules using it to try both (and default to the new name). Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9f343717f1f6d254b5b6992f2f82df28afc51033

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M checkout.py View 3 chunks +7 lines, -2 lines 2 comments Download
M third_party/upload.py View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vapier
spamming a few more people this time as an RFC. if people are OK with ...
4 years, 6 months ago (2016-06-16 18:52:13 UTC) #2
nodir
lgtm https://codereview.chromium.org/2076653002/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/2076653002/diff/1/checkout.py#newcode19 checkout.py:19: # The configparser module was renamed in Python ...
4 years, 6 months ago (2016-06-16 18:55:58 UTC) #3
vapier
https://codereview.chromium.org/2076653002/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/2076653002/diff/1/checkout.py#newcode19 checkout.py:19: # The configparser module was renamed in Python 3. ...
4 years, 6 months ago (2016-06-16 19:13:47 UTC) #4
nodir
lgtm
4 years, 6 months ago (2016-06-16 21:54:03 UTC) #5
tandrii(chromium)
lgtm
4 years, 6 months ago (2016-06-17 16:27:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076653002/1
4 years, 6 months ago (2016-06-22 14:10:01 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:13:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9f343717f1f6d2...

Powered by Google App Engine
This is Rietveld 408576698