Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2076643002: git cl upload: stop using deprecated except syntax (Closed)

Created:
4 years, 6 months ago by vapier
Modified:
4 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl upload: stop using deprecated except syntax The newer form works with python2 and python3. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2cc483c1d228f613c14095f656b9b5c64e67872e

Patch Set 1 #

Patch Set 2 : fix typo in OSError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/upload.py View 1 9 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vapier
4 years, 6 months ago (2016-06-16 18:45:01 UTC) #2
nodir
lgtm
4 years, 6 months ago (2016-06-16 18:59:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076643002/1
4 years, 6 months ago (2016-06-16 19:10:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/640)
4 years, 6 months ago (2016-06-16 19:15:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076643002/20001
4 years, 6 months ago (2016-06-16 19:23:48 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 19:27:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2cc483c1d228f6...

Powered by Google App Engine
This is Rietveld 408576698