Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2076633002: aw: Try to turn crash into java exception (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Try to turn crash into java exception Since I can't work out why things are null in native code anymore. BUG=618807 Committed: https://crrev.com/c731f40f3bfbcdd77bab19a0a45cd2f23e86bd6e Cr-Commit-Position: refs/heads/master@{#400690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
boliu
thoughts here? maybe get a second pair of eyes to check that all production callsites ...
4 years, 6 months ago (2016-06-16 18:42:57 UTC) #2
boliu
On 2016/06/16 18:42:57, boliu wrote: > thoughts here? > > maybe get a second pair ...
4 years, 6 months ago (2016-06-17 15:08:14 UTC) #3
Torne
lgtm
4 years, 6 months ago (2016-06-20 14:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076633002/1
4 years, 6 months ago (2016-06-20 15:09:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 15:55:55 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c731f40f3bfbcdd77bab19a0a45cd2f23e86bd6e Cr-Commit-Position: refs/heads/master@{#400690}
4 years, 6 months ago (2016-06-20 15:58:31 UTC) #9
boliu
4 years, 5 months ago (2016-06-27 03:01:02 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2099133002/ by boliu@chromium.org.

The reason for reverting is: Native crash still happens, which suggests
mNativeAwContents being null is not the issue..

Powered by Google App Engine
This is Rietveld 408576698