Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2076593002: base: In SHA-1 implementation use base::ByteSwap for endian conversion (Closed)

Created:
4 years, 6 months ago by robert.bradford
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: In SHA-1 implementation use base::ByteSwap for endian conversion With crrev.com/2077563002 enabling the use of builtins for byte swapping switch the SHA-1 implementation in base over to using the function in base/sys_byteorder.h BUG=620779 TEST=base_unittests:SHA1Test.* pass Committed: https://crrev.com/0bf0dd8041242ffcc13fd0a3ea840c255f25237f Cr-Commit-Position: refs/heads/master@{#400480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M base/sha1.cc View 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robert.bradford
danakj@ PTAL at this CL related to my other one you're also reviewing.
4 years, 6 months ago (2016-06-17 16:36:10 UTC) #2
danakj
LGTM
4 years, 6 months ago (2016-06-17 17:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076593002/1
4 years, 6 months ago (2016-06-17 18:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 20:11:16 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 20:13:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bf0dd8041242ffcc13fd0a3ea840c255f25237f
Cr-Commit-Position: refs/heads/master@{#400480}

Powered by Google App Engine
This is Rietveld 408576698