Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2076583002: Add WebAPK's tests in ChildProcessLauncherTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move all tests to //content. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
index 25bafd8c9f31eac1ef1fa9a3f9da910ca5a6a6b7..0aa52055caf7530dbce9cda135cef97ee82eee00 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
@@ -426,6 +426,14 @@ public class ChildProcessLauncher {
return connection;
}
+ private static ChildProcessConnection allocateConnection(Context context,
no sievers 2016/06/24 20:04:35 nit: is this function really useful or can it be f
Xi Han 2016/06/24 21:21:31 Done.
+ String[] commandLine, boolean inSandbox, boolean alwaysInForeground,
+ ChildProcessCreationParams creationParams) {
+ ChromiumLinkerParams chromiumLinkerParams = getLinkerParamsForNewConnection();
+ return allocateConnection(
+ context, inSandbox, chromiumLinkerParams, alwaysInForeground, creationParams);
+ }
+
private static final long FREE_CONNECTION_DELAY_MILLIS = 1;
private static void freeConnection(ChildProcessConnection connection) {
@@ -971,6 +979,12 @@ public class ChildProcessLauncher {
return allocateBoundConnection(context, null, true, false, creationParams);
}
+ @VisibleForTesting
+ static ChildProcessConnection allocateConnectionForTesting(Context context,
+ ChildProcessCreationParams creationParams) {
+ return allocateConnection(context, null, true, false, creationParams);
+ }
+
/**
* Queue up a spawn requests for testing.
*/
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698