Issue 2076543002: Gender-neutralize even more pronouns.

Issue 2076543002: Gender-neutralize even more pronouns. (Closed)

Created:
4 years, 6 months ago by Nico

Modified:
4 years, 6 months ago

Reviewers:
danakj

CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, nasko+codewatch_chromium.org, dcheng, ben+mojo_chromium.org, tapted, Matt Giuca, jam, abarth-chromium, darin-cc_chromium.org, kalyank, creis+watch_chromium.org, yzshen+watch_chromium.org, cc-bugs_chromium.org, dbeam+watch-settings_chromium.org, tfarina, Aaron Boodman, stevenjb+watch-md-settings_chromium.org, darin (slow to review), scheduler-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Gender-neutralize even more pronouns. No behavior change. BUG=none CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=various owners Committed: https://crrev.com/6ae1c3d4bb5e546c3c3bb4a3242204447af67988 Cr-Commit-Position: refs/heads/master@{#400299}

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -18 lines)			Patch
M	cc/scheduler/scheduler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/first_run/first_run_internal_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/lifetime/application_lifetime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_window.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/settings/reset_settings_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/cpp/system/watcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/views/app_list_drag_and_drop_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 15 (9 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

(fixed the cl description grammar) On Thu, Jun 16, 2016 at 4:03 PM, <thakis@chromium.org> wrote: ...

4 years, 6 months ago (2016-06-16 14:04:26 UTC) #7

(fixed the cl description grammar)

On Thu, Jun 16, 2016 at 4:03 PM, <thakis@chromium.org> wrote:

> Reviewers: danakj
> CL: https://codereview.chromium.org/2076543002/
>
> Description:
> Gender-neutralize a yet more comments.
>
> No behavior change.
>
> BUG=none
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+20, -18 lines):
> M cc/scheduler/scheduler_unittest.cc
> M chrome/browser/first_run/first_run.cc
> M chrome/browser/first_run/first_run_internal_win.cc
> M chrome/browser/lifetime/application_lifetime.h
> M chrome/browser/ui/browser_window.h
> M chrome/browser/ui/webui/settings/reset_settings_handler.h
> M chrome/common/pref_names.h
> M chrome/common/pref_names.cc
> M content/browser/frame_host/render_frame_host_impl.cc
> M mojo/public/cpp/system/watcher.cc
> M ui/app_list/views/app_list_drag_and_drop_host.h
> M ui/aura/window_unittest.cc
>
>
> Index: cc/scheduler/scheduler_unittest.cc
> diff --git a/cc/scheduler/scheduler_unittest.cc
> b/cc/scheduler/scheduler_unittest.cc
> index
>
e25d3b0c4bcfc37ba780e4d314ac6b1ee796b192..bf3b3f9a5e411d3b77fa941d9b500d8d468e7110
> 100644
> --- a/cc/scheduler/scheduler_unittest.cc
> +++ b/cc/scheduler/scheduler_unittest.cc
> @@ -952,7 +952,7 @@ TEST_F(SchedulerTest, PrepareTiles) {
> EXPECT_ACTION("WillBeginImplFrame", client, 0, 1);
> EXPECT_TRUE(scheduler_->BeginImplFrameDeadlinePending());
>
> - // On the deadline, he actions should have occured in the right order.
> + // On the deadline, the actions should have occured in the right order.
> client->Reset();
> task_runner().RunPendingTasks(); // Run posted deadline.
> EXPECT_EQ(1, client->num_draws());
> Index: chrome/browser/first_run/first_run.cc
> diff --git a/chrome/browser/first_run/first_run.cc
> b/chrome/browser/first_run/first_run.cc
> index
>
72945a63b443c94302c9cb01c20f054ad132aca1..f56eb8c1f3afa9cf986d38fc6511c323a8448c24
> 100644
> --- a/chrome/browser/first_run/first_run.cc
> +++ b/chrome/browser/first_run/first_run.cc
> @@ -520,8 +520,8 @@ void SetupMasterPrefsFromInstallPrefs(
>
> // If we're suppressing the first-run bubble, set that preference now.
> // Otherwise, wait until the user has completed first run to set it, so the
> - // user is guaranteed to see the bubble iff he or she has completed the
> first
> - // run process.
> + // user is guaranteed to see the bubble iff they have completed the
> first run
> + // process.
> if (install_prefs.GetBool(
> installer::master_preferences::kDistroSuppressFirstRunBubble,
> &value) && value)
> Index: chrome/browser/first_run/first_run_internal_win.cc
> diff --git a/chrome/browser/first_run/first_run_internal_win.cc
> b/chrome/browser/first_run/first_run_internal_win.cc
> index
>
3c479df4c669ff5dfc4bb57c5cb893986f6ce0ec..2fb7c2af650ccc9f6248d42173d76ca3751ed7fc
> 100644
> --- a/chrome/browser/first_run/first_run_internal_win.cc
> +++ b/chrome/browser/first_run/first_run_internal_win.cc
> @@ -110,7 +110,7 @@ void DoPostImportPlatformSpecificTasks(Profile* /*
> profile */) {
> // configuring this user's install (e.g. per-user shortcuts).
> // Delay the task slightly to give Chrome launch I/O priority while also
> // making sure shortcuts are created promptly to avoid annoying the user by
> - // re-creating shortcuts he previously deleted.
> + // re-creating shortcuts they previously deleted.
> static const int64_t kTiggerActiveSetupDelaySeconds = 5;
> base::FilePath chrome_exe;
> if (!PathService::Get(base::FILE_EXE, &chrome_exe)) {
> Index: chrome/browser/lifetime/application_lifetime.h
> diff --git a/chrome/browser/lifetime/application_lifetime.h
> b/chrome/browser/lifetime/application_lifetime.h
> index
>
55bf2f8104f39d66f0d6dc9b169bd4ab20e3d4a2..2d426ae8a94698cd3acf939ab2f1a6f93be81b18
> 100644
> --- a/chrome/browser/lifetime/application_lifetime.h
> +++ b/chrome/browser/lifetime/application_lifetime.h
> @@ -36,7 +36,7 @@ void AttemptRelaunch();
> // when no more windows are remaining. On other platforms (the Mac),
> // this will additionally exit the application if all browsers are
> // successfully closed.
> -// Note that he exit process may be interrupted by download or
> +// Note that the exit process may be interrupted by download or
> // unload handler, and the browser may or may not exit.
> void AttemptExit();
>
> Index: chrome/browser/ui/browser_window.h
> diff --git a/chrome/browser/ui/browser_window.h
> b/chrome/browser/ui/browser_window.h
> index
>
dc33811144dfbac498605de9115ee6f3dc01adf1..4c54625686678b000489c684d7e410c4c6ad1998
> 100644
> --- a/chrome/browser/ui/browser_window.h
> +++ b/chrome/browser/ui/browser_window.h
> @@ -283,8 +283,8 @@ class BrowserWindow : public ui::BaseWindow {
> bool app_modal,
> const base::Callback<void(bool)>& callback) = 0;
>
> - // ThemeService calls this when a user has changed his or her theme,
> - // indicating that it's time to redraw everything.
> + // ThemeService calls this when a user has changed their theme,
> indicating
> + // that it's time to redraw everything.
> virtual void UserChangedTheme() = 0;
>
> // Shows the website settings using the specified information.
> |virtual_url|
> Index: chrome/browser/ui/webui/settings/reset_settings_handler.h
> diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler.h
> b/chrome/browser/ui/webui/settings/reset_settings_handler.h
> index
>
b8e6cd7bae1d0395b92f5afcbcbf4b2cd3ec1a11..fd1782d6531b0985f1600006f0ed5dd677ef4776
> 100644
> --- a/chrome/browser/ui/webui/settings/reset_settings_handler.h
> +++ b/chrome/browser/ui/webui/settings/reset_settings_handler.h
> @@ -74,7 +74,7 @@ class ResetSettingsHandler : public
> SettingsPageUIHandler {
> void OnSettingsFetched();
>
> // Resets profile settings to default values. |send_settings| is true if
> user
> - // gave his consent to upload broken settings to Google for analysis.
> + // gave their consent to upload broken settings to Google for analysis.
> void ResetProfile(std::string callback_id, bool send_settings);
>
> // Closes the dialog once all requested settings has been reset.
> Index: chrome/common/pref_names.cc
> diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
> index
>
d47493512fa0a027b1bf6d8eb0521224773b5ccd..6b8fa7ea79f56f77c17ed39de7999484aaff6b01
> 100644
> --- a/chrome/common/pref_names.cc
> +++ b/chrome/common/pref_names.cc
> @@ -147,9 +147,10 @@ const char kSupervisedUserSharedSettings[] =
> "profile.managed.shared_settings";
> const char kSupervisedUserWhitelists[] = "profile.managed.whitelists";
>
> // The application locale.
> -// For OS_CHROMEOS we maintain kApplicationLocale property in both local
> state
> -// and user's profile. Global property determines locale of login screen,
> -// while user's profile determines his personal locale preference.
> +// For OS_CHROMEOS we maintain the kApplicationLocale property in both
> local
> +// state and the user's profile. The global property determines the
> locale of
> +// the login screen, while the user's profile determines their personal
> locale
> +// preference.
> const char kApplicationLocale[] = "intl.app_locale";
> #if defined(OS_CHROMEOS)
> // Locale preference of device' owner. ChromeOS device appears in this
> locale
> Index: chrome/common/pref_names.h
> diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
> index
>
cd01f6168a4596204e14544cfabbad9eb4537110..2510bd88758ff5885c0c4c1ae6fe4abc6a87467c
> 100644
> --- a/chrome/common/pref_names.h
> +++ b/chrome/common/pref_names.h
> @@ -48,9 +48,10 @@ extern const char kSupervisedUserSharedSettings[];
> extern const char kSupervisedUserWhitelists[];
> extern const char kURLsToRestoreOnStartup[];
>
> -// For OS_CHROMEOS we maintain kApplicationLocale property in both local
> state
> -// and user's profile. Global property determines locale of login screen,
> -// while user's profile determines his personal locale preference.
> +// For OS_CHROMEOS we maintain the kApplicationLocale property in both
> local
> +// state and the user's profile. The global property determines the
> locale of
> +// the login screen, while the user's profile determines their personal
> locale
> +// preference.
> extern const char kApplicationLocale[];
> #if defined(OS_CHROMEOS)
> extern const char kApplicationLocaleBackup[];
> Index: content/browser/frame_host/render_frame_host_impl.cc
> diff --git a/content/browser/frame_host/render_frame_host_impl.cc
> b/content/browser/frame_host/render_frame_host_impl.cc
> index
>
3855d7ee223446aa05e556519fe12961131e149a..20a458ba9208125ae6eef2d014343d149456bac4
> 100644
> --- a/content/browser/frame_host/render_frame_host_impl.cc
> +++ b/content/browser/frame_host/render_frame_host_impl.cc
> @@ -2208,7 +2208,7 @@ void RenderFrameHostImpl::DispatchBeforeUnload(bool
> for_navigation,
> this, "&RenderFrameHostImpl", (void*)this);
>
> // This may be called more than once (if the user clicks the tab close
> button
> - // several times, or if she clicks the tab close button then the browser
> close
> + // several times, or if they click the tab close button then the browser
> close
> // button), and we only send the message once.
> if (is_waiting_for_beforeunload_ack_) {
> // Some of our close messages could be for the tab, others for cross-site
> Index: mojo/public/cpp/system/watcher.cc
> diff --git a/mojo/public/cpp/system/watcher.cc
> b/mojo/public/cpp/system/watcher.cc
> index
>
10cf63412626cb245f77415f8a3cd4f556e443af..d9319fb5bda1fc368378a77e15de03b941783a9e
> 100644
> --- a/mojo/public/cpp/system/watcher.cc
> +++ b/mojo/public/cpp/system/watcher.cc
> @@ -130,7 +130,7 @@ void Watcher::CallOnHandleReady(uintptr_t context,
> // NOTE: It is safe to assume the Watcher still exists because this
> callback
> // will never be run after the Watcher's destructor.
> //
> - // TODO: Maybe we should also expose |signals_state| throught he Watcher
> API.
> + // TODO: Maybe we should also expose |signals_state| through the Watcher
> API.
> // Current HandleWatcher users have no need for it, so it's omitted here.
> Watcher* watcher = reinterpret_cast<Watcher*>(context);
> if ((flags & MOJO_WATCH_NOTIFICATION_FLAG_FROM_SYSTEM) &&
> Index: ui/app_list/views/app_list_drag_and_drop_host.h
> diff --git a/ui/app_list/views/app_list_drag_and_drop_host.h
> b/ui/app_list/views/app_list_drag_and_drop_host.h
> index
>
7680dfdb4598275bc0ba066bf4e9de05d6d5d8db..65451363a6782852a561a244e4b2e3098f61c307
> 100644
> --- a/ui/app_list/views/app_list_drag_and_drop_host.h
> +++ b/ui/app_list/views/app_list_drag_and_drop_host.h
> @@ -43,7 +43,7 @@ class ApplicationDragAndDropHost {
> virtual void DestroyDragIconProxy() = 0;
>
> // A drag operation could get started. The recipient has to return true if
> - // he wants to take it - e.g. |location_in_screen_poordinates| is over a
> + // it wants to take it - e.g. |location_in_screen_poordinates| is over a
> // target area. The passed |app_id| identifies the application which should
> // get dropped.
> virtual bool StartDrag(const std::string& app_id,
> Index: ui/aura/window_unittest.cc
> diff --git a/ui/aura/window_unittest.cc b/ui/aura/window_unittest.cc
> index
>
e39afe435906fbb1495e3aa8fd8f812d4804113c..0017c629100c8f0a71ea6fdcf2fbe88ee400db34
> 100644
> --- a/ui/aura/window_unittest.cc
> +++ b/ui/aura/window_unittest.cc
> @@ -563,7 +563,7 @@ TEST_F(WindowTest, GetEventHandlerForPoint) {
> }
>
> TEST_F(WindowTest, GetEventHandlerForPointWithOverride) {
> - // If our child is flush to our top-left corner he gets events just
> inside the
> + // If our child is flush to our top-left corner it gets events just
> inside the
> // window edges.
> std::unique_ptr<Window> parent(CreateTestWindow(
> SK_ColorWHITE, 1, gfx::Rect(10, 20, 400, 500), root_window()));
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076543002/1

4 years, 6 months ago (2016-06-16 23:02:36 UTC) #11

commit-bot: I haz the power

4 years, 6 months ago (2016-06-16 23:42:58 UTC) #15

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ae1c3d4bb5e546c3c3bb4a3242204447af67988
Cr-Commit-Position: refs/heads/master@{#400299}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages