Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2076493002: Revert of [turbofan] Properly handle dictionary maps in the prototype chain. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_CheckedOperators
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Properly handle dictionary maps in the prototype chain. (patchset #1 id:1 of https://codereview.chromium.org/2067423003/ ) Reason for revert: As discussed offline with Toon, this is not the correct fix here. Original issue's description: > [turbofan] Properly handle dictionary maps in the prototype chain. > > Dictionary prototypes don't have stable maps, but still don't matter for > element access. Generalized the JSNativeContextSpecialization a bit to > handle everything that Crankshaft can handle in this regard. > > R=jarin@chromium.org > BUG=chromium:616709 > > Committed: https://crrev.com/1c7bdc7f6f4d9512f4982590bd949f265ee9c8c3 > Cr-Commit-Position: refs/heads/master@{#37019} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616709 Committed: https://crrev.com/47fb39e4de283b3aca5c655628b3f4d195c7563f Cr-Commit-Position: refs/heads/master@{#37029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -61 lines) Patch
M src/compilation-dependencies.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compilation-dependencies.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +11 lines, -34 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-616709.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Created Revert of [turbofan] Properly handle dictionary maps in the prototype chain.
4 years, 6 months ago (2016-06-16 09:14:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076493002/1
4 years, 6 months ago (2016-06-16 09:14:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 09:15:06 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 09:15:07 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 09:17:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47fb39e4de283b3aca5c655628b3f4d195c7563f
Cr-Commit-Position: refs/heads/master@{#37029}

Powered by Google App Engine
This is Rietveld 408576698