testing/variations/fieldtrial_testing_config_android.json - Issue 2076463002: [Custom Tabs] Implement "Read It Later" Behind a Flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/variations/fieldtrial_testing_config_android.json

Issue 2076463002: [Custom Tabs] Implement "Read It Later" Behind a Flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/browser/android/chrome_feature_list.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: testing/variations/fieldtrial_testing_config_android.json

diff --git a/testing/variations/fieldtrial_testing_config_android.json b/testing/variations/fieldtrial_testing_config_android.json

index 3a22f8a64bf8685776bf0acd6ec6f94e9bdf8551..7508002f5f77249ecb766ca922cec10555a48b94 100644

--- a/testing/variations/fieldtrial_testing_config_android.json

+++ b/testing/variations/fieldtrial_testing_config_android.json

@@ -302,6 +302,20 @@

"group_name": "Enabled"

}

+ "ReadItLater": [

+ {

+ "enable_features": [

+ "ReadItLaterInMenu"

+ ],

+ "group_name": "Enabled"

+ },

+ {

+ "disable_features": [

+ "ReadItLaterInMenu"

+ ],

+ "group_name": "Control"

+ }

Ilya Sherman 2016/06/16 03:57:50 Please omit the control group -- only the new grou

Ian Wen 2016/06/16 21:09:00 Did you mean that I just remove the entire second

Ilya Sherman 2016/06/16 23:12:53 Exactamundo =)

+ ],

"ReaderModeUI": [

{

"group_name": "AdaBoost"

« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/browser/android/chrome_feature_list.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »