chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java - Issue 2076463002: [Custom Tabs] Implement "Read It Later" Behind a Flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

Issue 2076463002: [Custom Tabs] Implement "Read It Later" Behind a Flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

index 0948e20af680badaed2e89eece1d073fa412ac78..e3bac5c19174b792f3fca4ebd5087ed2b21e8674 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

@@ -16,6 +16,7 @@ import org.chromium.base.BuildInfo;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;

import org.chromium.chrome.browser.share.ShareHelper;

import org.chromium.chrome.browser.tab.Tab;

@@ -104,11 +105,17 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat

}

MenuItem openInChromeItem = menu.findItem(R.id.open_in_browser_id);

- try {

- openInChromeItem.setTitle(mDefaultBrowserFetcher.get());

- } catch (InterruptedException | ExecutionException e) {

- openInChromeItem.setTitle(

- mActivity.getString(R.string.menu_open_in_product_default));

+ MenuItem readItLaterItem = menu.findItem(R.id.read_it_later_id);

+ if (ChromeFeatureList.isEnabled("ReadItLaterInMenu")) {

+ openInChromeItem.setTitle(R.string.menu_open_in_chrome);

gone 2016/06/16 18:07:58 Any reason why this string is different in this ca

Ian Wen 2016/06/16 21:09:00 Done.

+ } else {

+ readItLaterItem.setVisible(false);

+ try {

+ openInChromeItem.setTitle(mDefaultBrowserFetcher.get());

+ } catch (InterruptedException | ExecutionException e) {

+ openInChromeItem.setTitle(

+ mActivity.getString(R.string.menu_open_in_product_default));

+ }

}

// Add custom menu items. Make sure they are only added once.