[Custom Tabs] Implement "Read It Later" Behind a Flag

[Custom Tabs] Implement "Read It Later" Behind a Flag

This CL implements "read it later" feature and puts the feature behind a
flag. The trial name is "ReadItLater". When this mode is turned on,
reparented tab will stay visible for 600MS and then the activity is
pushed to back of the recent stack.

BUG=620535
Committed: https://crrev.com/ea63767b61ae1a8935b420685bbee58467b68b5b
Cr-Commit-Position: refs/heads/master@{#400524}

[Ian Wen, 2016-06-16 01:45:18]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org, isherman@chromium.org

[Ian Wen, 2016-06-16 01:45:18]

PTAL

[Ilya Sherman, 2016-06-16 03:57:50]

actions.xml and field trial testing config changes lgtm

https://codereview.chromium.org/2076463002/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config_android.json (right):

https://codereview.chromium.org/2076463002/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config_android.json:317: }
Please omit the control group -- only the new group should be included in this
testing config.

[gone, 2016-06-16 18:07:58]

lgtm

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:110:
openInChromeItem.setTitle(R.string.menu_open_in_chrome);
Any reason why this string is different in this case?

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:2280: Your tab is now
sent to background.
Your tab was sent to the background?
Your tab is now in the background?

[Ian Wen, 2016-06-16 21:09:00]

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:110:
openInChromeItem.setTitle(R.string.menu_open_in_chrome);
On 2016/06/16 18:07:58, dfalcantara wrote:
> Any reason why this string is different in this case?

Done.

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:2280: Your tab is now
sent to background.
On 2016/06/16 18:07:58, dfalcantara wrote:
> Your tab was sent to the background?
> Your tab is now in the background?

Done.

https://chromiumcodereview.appspot.com/2076463002/diff/1/testing/variations/f...
File testing/variations/fieldtrial_testing_config_android.json (right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/testing/variations/f...
testing/variations/fieldtrial_testing_config_android.json:317: }
On 2016/06/16 03:57:50, Ilya Sherman wrote:
> Please omit the control group -- only the new group should be included in this
> testing config.

Did you mean that I just remove the entire second {} bracket?

[Ian Wen, 2016-06-16 21:09:15]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 21:10:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076463002/20001

[commit-bot: I haz the power, 2016-06-16 21:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 21:31:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Ian Wen, 2016-06-16 22:02:18]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-06-16 22:02:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2076463002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-06-16 22:03:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076463002/40001

[Ilya Sherman, 2016-06-16 23:12:53]

https://chromiumcodereview.appspot.com/2076463002/diff/1/testing/variations/f...
File testing/variations/fieldtrial_testing_config_android.json (right):

https://chromiumcodereview.appspot.com/2076463002/diff/1/testing/variations/f...
testing/variations/fieldtrial_testing_config_android.json:317: }
On 2016/06/16 21:09:00, Ian Wen wrote:
> On 2016/06/16 03:57:50, Ilya Sherman wrote:
> > Please omit the control group -- only the new group should be included in
this
> > testing config.
> 
> Did you mean that I just remove the entire second {} bracket?

Exactamundo =)

[commit-bot: I haz the power, 2016-06-17 03:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 03:00:44]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-06-17 21:03:06]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-06-17 21:03:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2076463002/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2016-06-17 21:03:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076463002/60001

[commit-bot: I haz the power, 2016-06-17 22:17:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-17 22:19:50]

Description was changed from

==========
[Custom Tabs] Implement "Read It Later" Behind a Flag

This CL implements "read it later" feature and puts the feature behind a
flag. The trial name is "ReadItLater". When this mode is turned on,
reparented tab will stay visible for 600MS and then the activity is
pushed to back of the recent stack.

BUG=620535
==========

to

==========
[Custom Tabs] Implement "Read It Later" Behind a Flag

This CL implements "read it later" feature and puts the feature behind a
flag. The trial name is "ReadItLater". When this mode is turned on,
reparented tab will stay visible for 600MS and then the activity is
pushed to back of the recent stack.

BUG=620535

Committed: https://crrev.com/ea63767b61ae1a8935b420685bbee58467b68b5b
Cr-Commit-Position: refs/heads/master@{#400524}
==========

[commit-bot: I haz the power, 2016-06-17 22:19:51]

Patchset 4 (id:??) landed as
https://crrev.com/ea63767b61ae1a8935b420685bbee58467b68b5b
Cr-Commit-Position: refs/heads/master@{#400524}