Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2076423003: Adjust WebAudio test thresholds for OSX 10.11 (Closed)

Created:
4 years, 6 months ago by Raymond Toy
Modified:
4 years, 6 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust WebAudio test thresholds for OSX 10.11 Slightly adjust thresholds for these tests so that they pass on OSX 10.11. Differences are presumably because the FFT routines have changed slightly. BUG=621527 TESTS=osc-negative-freq, realtimeanalyser-freq-data Committed: https://crrev.com/a2d70088e66ce3b018e799b24fe48ee8b30edaef Cr-Commit-Position: refs/heads/master@{#400739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/osc-negative-freq.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-negative-freq-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raymond Toy
PTAL.
4 years, 6 months ago (2016-06-20 15:00:30 UTC) #2
hongchan
lgtm
4 years, 6 months ago (2016-06-20 15:53:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076423003/1
4 years, 6 months ago (2016-06-20 15:58:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 18:49:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:54:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2d70088e66ce3b018e799b24fe48ee8b30edaef
Cr-Commit-Position: refs/heads/master@{#400739}

Powered by Google App Engine
This is Rietveld 408576698