Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2076413002: Handle pagination breaking on rows correctly when a table has >1 section (Closed)

Created:
4 years, 6 months ago by rhogan
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@345972
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle pagination breaking on rows correctly when a table has >1 section When a table has more than one section, layoutRows() needs to have an up-to-date logicalTop() for the section. Otherwise it will calculate the wrong offset from the top of the page for the row when figuring out whether to put a strut on it. BUG=621359 Committed: https://crrev.com/5aca76371f4c851adb4b1ac398ac45d62073967b Cr-Commit-Position: refs/heads/master@{#400941}

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : bug 621359 #

Patch Set 4 : bug 621359 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-in-multiple-table-sections.html View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-in-multiple-table-sections-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
rhogan
When a table has more than one section, layoutRows() needs to have an up-to-date logicalTop() ...
4 years, 6 months ago (2016-06-20 18:47:41 UTC) #2
eae
LGTM
4 years, 6 months ago (2016-06-21 09:08:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076413002/60001
4 years, 6 months ago (2016-06-21 09:09:52 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-21 10:26:44 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 10:29:28 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5aca76371f4c851adb4b1ac398ac45d62073967b
Cr-Commit-Position: refs/heads/master@{#400941}

Powered by Google App Engine
This is Rietveld 408576698