Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: gni/v8.gni

Issue 2076403002: Use the new "optimize_speed" GN config. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rename config Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index ae26521a6a98fadad77aadc422689fff9cd27141..24f65679a4731518b729d8d4ab1f9767e68108c9 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/v8_target_cpu.gni")
+import("//build/config/sanitizers/sanitizers.gni")
declare_args() {
# Turns on compiler optimizations in V8 in Debug build.
@@ -39,7 +40,14 @@ if (is_debug && !v8_optimized_debug) {
add_configs += [ "//build/config/compiler:no_optimize" ]
} else {
remove_configs += [ "//build/config/compiler:default_optimization" ]
- add_configs += [ "//build/config/compiler:optimize_max" ]
+
+ # TODO(crbug.com/621335) Rework this so that we don't have the confusion
+ # between "optimize_speed" and "optimize_max".
+ if (is_posix && !is_android && !is_nacl && !using_sanitizer) {
+ add_configs += [ "//build/config/compiler:optimize_speed" ]
+ } else {
+ add_configs += [ "//build/config/compiler:optimize_max" ]
+ }
}
# All templates should be kept in sync.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698