Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2076403002: Use the new "optimize_speed" GN config. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use the new "optimize_speed" GN config. The GN configs for different optimization levels are confusing and should probably be reworked, but for now we add a special config specifically so that we can compile with -O3 when appropriate. R=brettw@chromium.org, machenbach@chromium.org BUG=616031, 618678, 621335 Committed: https://crrev.com/365e32b1302d7d9b97761d5037050b2200d1a323 Cr-Commit-Position: refs/heads/master@{#37158}

Patch Set 1 #

Patch Set 2 : update w/ review feedback #

Patch Set 3 : rename config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M gni/v8.gni View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Dirk Pranke
This patch depends on https://codereview.chromium.org/2078223002/ landing in chromium //build first and being rolled into v8 ...
4 years, 6 months ago (2016-06-19 05:14:31 UTC) #1
Michael Achenbach
lgtm % exact spelling of the config, e.g., optimize_target_for_speed vs optimize_posix_target_for_speed
4 years, 6 months ago (2016-06-20 11:44:44 UTC) #2
Dirk Pranke
Updated.
4 years, 6 months ago (2016-06-20 16:38:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076403002/40001
4 years, 6 months ago (2016-06-21 23:11:20 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 23:35:27 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 23:37:28 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/365e32b1302d7d9b97761d5037050b2200d1a323
Cr-Commit-Position: refs/heads/master@{#37158}

Powered by Google App Engine
This is Rietveld 408576698