Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: net/http/transport_security_state_unittest.cc

Issue 2076363002: Introduce the ability to require CT for specific hosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@require_ct_enforcer
Patch Set: Android is weird Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/quic/crypto/proof_verifier_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state_unittest.cc
diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc
index 7731ee56128d668c804eaa006c852669e9fdeb59..b513be170162b2d1935b3df85d2ce9a64a5987d2 100644
--- a/net/http/transport_security_state_unittest.cc
+++ b/net/http/transport_security_state_unittest.cc
@@ -33,6 +33,7 @@
#include "net/ssl/ssl_info.h"
#include "net/test/cert_test_util.h"
#include "net/test/test_data_directory.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -160,6 +161,12 @@ class MockExpectCTReporter : public TransportSecurityState::ExpectCTReporter {
uint32_t num_failures_;
};
+class MockRequireCTDelegate : public TransportSecurityState::RequireCTDelegate {
+ public:
+ MOCK_METHOD1(IsCTRequiredForHost,
+ CTRequirementLevel(const std::string& hostname));
+};
+
void CompareCertificateChainWithList(
const scoped_refptr<X509Certificate>& cert_chain,
const base::ListValue* cert_list) {
@@ -1883,4 +1890,71 @@ TEST_F(TransportSecurityStateTest, ExpectCTReporter) {
EXPECT_EQ(GURL(kExpectCTStaticReportURI), reporter.report_uri());
}
+// Tests that TransportSecurityState always consults the RequireCTDelegate,
+// if supplied.
+TEST_F(TransportSecurityStateTest, RequireCTConsultsDelegate) {
+ using ::testing::_;
+ using ::testing::Return;
+ using CTRequirementLevel =
+ TransportSecurityState::RequireCTDelegate::CTRequirementLevel;
+
+ // Dummy cert to use as the validate chain. The contents do not matter.
+ scoped_refptr<X509Certificate> cert =
+ ImportCertFromFile(GetTestCertsDirectory(), "expired_cert.pem");
+ ASSERT_TRUE(cert);
+
+ HashValueVector hashes;
+ hashes.push_back(HashValue(
+ X509Certificate::CalculateFingerprint256(cert->os_cert_handle())));
+
+ {
+ TransportSecurityState state;
+ bool original_status =
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes);
+
+ MockRequireCTDelegate always_require_delegate;
+ EXPECT_CALL(always_require_delegate, IsCTRequiredForHost(_))
+ .WillRepeatedly(Return(CTRequirementLevel::REQUIRED));
+ state.SetRequireCTDelegate(&always_require_delegate);
+ EXPECT_TRUE(state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+
+ state.SetRequireCTDelegate(nullptr);
+ EXPECT_EQ(original_status,
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+ }
+
+ {
+ TransportSecurityState state;
+ bool original_status =
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes);
+
+ MockRequireCTDelegate never_require_delegate;
+ EXPECT_CALL(never_require_delegate, IsCTRequiredForHost(_))
+ .WillRepeatedly(Return(CTRequirementLevel::NOT_REQUIRED));
+ state.SetRequireCTDelegate(&never_require_delegate);
+ EXPECT_FALSE(state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+
+ state.SetRequireCTDelegate(nullptr);
+ EXPECT_EQ(original_status,
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+ }
+
+ {
+ TransportSecurityState state;
+ bool original_status =
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes);
+
+ MockRequireCTDelegate default_require_ct_delegate;
+ EXPECT_CALL(default_require_ct_delegate, IsCTRequiredForHost(_))
+ .WillRepeatedly(Return(CTRequirementLevel::DEFAULT));
+ state.SetRequireCTDelegate(&default_require_ct_delegate);
+ EXPECT_EQ(original_status,
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+
+ state.SetRequireCTDelegate(nullptr);
+ EXPECT_EQ(original_status,
+ state.ShouldRequireCT("www.example.com", cert.get(), hashes));
+ }
+}
+
} // namespace net
« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/quic/crypto/proof_verifier_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698