Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2076353002: Record NQE ECT at main frame (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record NQE ECT at main frame This will help in establishing the correlation between page-level metrics (such as PLT), and ECT. BUG=614572 Committed: https://crrev.com/2052c61710876afbc63a0ff159509f91a152812b Cr-Commit-Position: refs/heads/master@{#401383}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M net/nqe/network_quality_estimator.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 6 chunks +32 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
tbansal1
kundaji: ptal. Thanks.
4 years, 6 months ago (2016-06-18 00:38:56 UTC) #4
Not at Google. Contact bengr
lgtm
4 years, 6 months ago (2016-06-20 16:03:42 UTC) #5
tbansal1
bengr: ptal. Thanks.
4 years, 6 months ago (2016-06-20 18:34:58 UTC) #7
bengr
lgtm. Please flesh out the CL description. https://codereview.chromium.org/2076353002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2076353002/diff/20001/tools/metrics/histograms/histograms.xml#newcode34824 tools/metrics/histograms/histograms.xml:34824: + Effective ...
4 years, 6 months ago (2016-06-20 20:11:24 UTC) #8
tbansal1
asvitkine: ptal. Thanks.
4 years, 6 months ago (2016-06-20 20:27:49 UTC) #11
tbansal1
rkaplow: PTAL at histograms.xml. Thanks.
4 years, 6 months ago (2016-06-20 22:50:43 UTC) #13
rkaplow
lgtm
4 years, 6 months ago (2016-06-21 14:39:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076353002/40001
4 years, 6 months ago (2016-06-22 18:13:36 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-22 19:48:47 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 19:50:00 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2052c61710876afbc63a0ff159509f91a152812b
Cr-Commit-Position: refs/heads/master@{#401383}

Powered by Google App Engine
This is Rietveld 408576698