Move new expression parsing funcs to ParserBase.

Move new expression parsing funcs to ParserBase.

Functions moved: ParseMemberWithNewPrefixesExpression, ParseMemberExpression,
ParseMemberExpressionContinuation.

Now all Parse*Expression functions are in ParserBase.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20153

[marja, 2014-03-21 08:55:10]

mstarzinger, ptal.

The intended order for the 3 CLs:

https://codereview.chromium.org/202333004/ (postfix)
https://codereview.chromium.org/206433003/ (lefthandside)
https://codereview.chromium.org/207633003/ (this)

[Michael Starzinger, 2014-03-21 10:09:59]

LGTM with nits.

https://codereview.chromium.org/207633003/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/207633003/diff/1/src/parser.h#newcode478
src/parser.h:478: void MaybePushPropertyName(FuncNameInferrer* fni, Expression*
expression);
nit: Can we call this PushPropertyOrLiteralName, because "maybe" sounds
misleading in the sense that it suggests there are cases where nothing is
pushed.

https://codereview.chromium.org/207633003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/207633003/diff/1/src/preparser.h#newcode878
src/preparser.h:878: ASSERT(false);
nit: s/ASSERT(false)/UNREACHABLE/ here and above.

[marja, 2014-03-21 10:28:24]

t

https://codereview.chromium.org/207633003/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/207633003/diff/1/src/parser.h#newcode478
src/parser.h:478: void MaybePushPropertyName(FuncNameInferrer* fni, Expression*
expression);
On 2014/03/21 10:09:59, Michael Starzinger wrote:
> nit: Can we call this PushPropertyOrLiteralName, because "maybe" sounds
> misleading in the sense that it suggests there are cases where nothing is
> pushed.

-> PushPropertyName as discussed offline

https://codereview.chromium.org/207633003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/207633003/diff/1/src/preparser.h#newcode878
src/preparser.h:878: ASSERT(false);
On 2014/03/21 10:09:59, Michael Starzinger wrote:
> nit: s/ASSERT(false)/UNREACHABLE/ here and above.

Done.

[marja, 2014-03-21 10:34:58]

Committed patchset #2 manually as r20153 (presubmit successful).