Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2076313002: Mojo C++ bindings: expose serialization public API for mojo structs. (Closed)

Created:
4 years, 6 months ago by yzshen1
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: expose serialization public API for mojo structs. BUG=597115 Committed: https://crrev.com/9abf5980f6324f6bceccab2ee27b98daffed8aec Cr-Commit-Position: refs/heads/master@{#400537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -2 lines) Patch
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +89 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/struct_ptr.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_wtf_types.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
yzshen1
Hi, Scott and Ken. Please take a look. Do you think it is also useful ...
4 years, 6 months ago (2016-06-17 21:37:49 UTC) #2
Ken Rockot(use gerrit already)
LGTM - Yes I think it makes sense to also provide a similar API for ...
4 years, 6 months ago (2016-06-17 22:08:06 UTC) #3
sky
I haven't a clue about this code, but I certainly like how the test looks. ...
4 years, 6 months ago (2016-06-17 23:06:32 UTC) #4
sky
Just to be clear, don't wait for me to review this one. It's all Ken.
4 years, 6 months ago (2016-06-17 23:07:03 UTC) #5
yzshen1
On 2016/06/17 23:07:03, sky wrote: > Just to be clear, don't wait for me to ...
4 years, 6 months ago (2016-06-17 23:10:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076313002/1
4 years, 6 months ago (2016-06-17 23:11:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 23:16:32 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 23:17:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9abf5980f6324f6bceccab2ee27b98daffed8aec
Cr-Commit-Position: refs/heads/master@{#400537}

Powered by Google App Engine
This is Rietveld 408576698