Delete query in omnibox code. R.I.P.

Delete query in omnibox code. R.I.P.

BUG=621192
Committed: https://crrev.com/7f29afb7f6754f534fe754f9a23062a8aabaf834
Cr-Commit-Position: refs/heads/master@{#400548}

[Maria, 2016-06-17 20:46:46]

mariakhomenko@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-06-17 21:20:31]

https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1988:
if (!TextUtils.isEmpty(displayText) && mToolbarDataProvider.wouldReplaceURL()) {
is this block even necessary anymore?  if we do use wouldReplaceURL, isn't that
essentially query in the omnibox?

should we be asserting that wouldReplaceURL is false otherwise we're have
supporting query in the omnibox right?

[Maria, 2016-06-17 22:06:07]

mariakhomenko@chromium.org changed reviewers:
+ pkasting@chromium.org

[Maria, 2016-06-17 22:06:07]

+ peter for components/ approvals

[Maria, 2016-06-17 22:06:43]

https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1988:
if (!TextUtils.isEmpty(displayText) && mToolbarDataProvider.wouldReplaceURL()) {
On 2016/06/17 21:20:31, Ted C wrote:
> is this block even necessary anymore?  if we do use wouldReplaceURL, isn't
that
> essentially query in the omnibox?
> 
> should we be asserting that wouldReplaceURL is false otherwise we're have
> supporting query in the omnibox right?

Good catch.

[Ted C, 2016-06-17 22:13:12]

On 2016/06/17 22:06:43, Maria wrote:
>
https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
> (right):
> 
>
https://codereview.chromium.org/2076303002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1988:
> if (!TextUtils.isEmpty(displayText) && mToolbarDataProvider.wouldReplaceURL())
{
> On 2016/06/17 21:20:31, Ted C wrote:
> > is this block even necessary anymore?  if we do use wouldReplaceURL, isn't
> that
> > essentially query in the omnibox?
> > 
> > should we be asserting that wouldReplaceURL is false otherwise we're have
> > supporting query in the omnibox right?
> 
> Good catch.

lgtm

[Maria, 2016-06-17 22:31:16]

The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:31:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076303002/20001

[Peter Kasting, 2016-06-17 22:51:33]

LGTM

https://codereview.chromium.org/2076303002/diff/20001/components/toolbar/tool...
File components/toolbar/toolbar_model_impl.cc (left):

https://codereview.chromium.org/2076303002/diff/20001/components/toolbar/tool...
components/toolbar/toolbar_model_impl.cc:75: const std::string&
query_str(google_util::HasGoogleSearchQueryParam(
I think removing this means we can remove the google_util.h #include.

Please check whether any other #includes are now dead as well.

[Maria, 2016-06-17 23:08:46]

https://codereview.chromium.org/2076303002/diff/20001/components/toolbar/tool...
File components/toolbar/toolbar_model_impl.cc (left):

https://codereview.chromium.org/2076303002/diff/20001/components/toolbar/tool...
components/toolbar/toolbar_model_impl.cc:75: const std::string&
query_str(google_util::HasGoogleSearchQueryParam(
On 2016/06/17 22:51:33, Peter Kasting wrote:
> I think removing this means we can remove the google_util.h #include.
> 
> Please check whether any other #includes are now dead as well.

Done.

[Maria, 2016-06-17 23:08:55]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-06-17 23:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2076303002/#ps40001
(title: "Remove unused header.")

[commit-bot: I haz the power, 2016-06-17 23:09:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076303002/40001

[commit-bot: I haz the power, 2016-06-18 00:13:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-18 00:15:59]

Description was changed from

==========
Delete query in omnibox code. R.I.P.

BUG=621192
==========

to

==========
Delete query in omnibox code. R.I.P.

BUG=621192

Committed: https://crrev.com/7f29afb7f6754f534fe754f9a23062a8aabaf834
Cr-Commit-Position: refs/heads/master@{#400548}
==========

[commit-bot: I haz the power, 2016-06-18 00:16:00]

Patchset 3 (id:??) landed as
https://crrev.com/7f29afb7f6754f534fe754f9a23062a8aabaf834
Cr-Commit-Position: refs/heads/master@{#400548}