Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2076133002: Trace active script wrappables on entering final pause (Closed)

Created:
4 years, 6 months ago by Marcel Hlopko
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trace active script wrappables on entering final pause V8 now tells EmbedderHeapTracer when it enters the final pause, and that is exactly the place where we need to trace active script wrappables. Previous implementation is not correct. LOG=no BUG=468240 Committed: https://crrev.com/951fd10c953cffb097fde5b2e926550cdca9d27a Cr-Commit-Position: refs/heads/master@{#400634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Ptal.
4 years, 6 months ago (2016-06-17 11:12:45 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-17 12:47:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076133002/1
4 years, 6 months ago (2016-06-20 05:49:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 08:09:14 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 08:12:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/951fd10c953cffb097fde5b2e926550cdca9d27a
Cr-Commit-Position: refs/heads/master@{#400634}

Powered by Google App Engine
This is Rietveld 408576698